search

BP-WG / descriptor-wallet

Library for building descriptor-based bitcoin wallets using rust-bitcoin
Apache License 2.0
58 stars 26 forks source link

Why re-publishing `hwi` crate as `bitcoin_hwi` ? #38

Open notmandatory opened 2 years ago

notmandatory commented 2 years ago

Hi @dr-orlovsky I see that you have re-published the hwi crate from bitcoindevkit/rust-hwi as a new bitcoin_hwi crate with some small additional commits. Would you be willing to add these changes to the original project by submitting a PR and yank your bitcoin_hwi crate so we don't have two nearly identical projects published to crates.io?

dr-orlovsky commented 2 years ago

Hi! My plan is to rewrite the crate from scratch over the summer. I started with cloning for now not to wait for the PRs to be merged - I have to do a lot of releases over the summer.

Feel free to pick up the commits from here for now to the upstream.

notmandatory commented 2 years ago

Where can I find your fork ? I don't mind opening PRs to try and upstream your commits if they're generally useful to other users of rust-hwi.

dr-orlovsky commented 2 years ago

Hm, I am confused, I thought it is here, should be in hwi subdirectory of this repo. Ok, searching for it...

dr-orlovsky commented 2 years ago

Seems like I changed it somewhere locally and didn't pushed to GitHub :( Now I can't find it even on disk.

Anyway, the change was in adding more derives to a Error type and adding Copy/Clone to some of the data types, so it was ultra-trivial.

The purpose of my future crate rewrite will be using libusb directly from rust, avoiding interface through command line

notmandatory commented 2 years ago

OK for now I'll put in a PR to rust-hwi to add the missing derived traits but of course it's up to you if you want to use it in your project or use your own lib. I do think you should provide a link to the source for your current bitcoind_hwi crate so that the original MIT license copyright requirement is respected.

dr-orlovsky commented 2 years ago

Absolutely. I have very tight schedule until the 26th of June (releasing RGB after 3 yrs of work), but after I will download source from the crates.io and re-create the repo with my changes - and will do a PR against the original repo.

notmandatory commented 2 years ago

Thanks, I'll review your PR when you're ready.

dr-orlovsky commented 2 years ago

@notmandatory can you please add license information to the rust-hwi crate since it currently misses one and it is unclear which conditions for its use and code modification apply

dr-orlovsky commented 2 years ago

I found the repo, here it is: https://github.com/mycitadel/bitcoin_hwi I checked - most of my changes there were already done in the main repo in the last weeks. The rest are related to a dependency I've added (amplify) to do Display derives for the error types, which probably would not be accepted upstream. Let me know if you need it.

notmandatory commented 2 years ago

@notmandatory can you please add license information to the rust-hwi crate since it currently misses one and it is unclear which conditions for its use and code modification apply

Hi sorry for the delay. The Cargo.toml for the rust-hwi repo specifies the license is MIT. I've created a small PR to make it more explicit, does this help? https://github.com/bitcoindevkit/rust-hwi/pull/38