search

BP-WG / descriptor-wallet

Library for building descriptor-based bitcoin wallets using rust-bitcoin
Apache License 2.0
59 stars 26 forks source link

Remove strict_encoding dependency #5

Open dr-orlovsky opened 3 years ago

dr-orlovsky commented 3 years ago

Crates are subjected to be used as a part of wider bitcoin ecosystem and should not be limited to client-side-validation only. Thus, strict encoding implementation for crate-defined types should be done inside strict_encoding crate, like it is done for bitcoin, miniscript, secp256k1 and other non-client-side-validation projects.

cryptoquick commented 2 years ago

This isn't quite clear. Are you saying, the types like the ones in descriptors/src/descriptor.rs that derive StrictEncode and StrictDecode should be moved into a separate strict_encoding crate? Could conditional compilation and features be used instead?

dr-orlovsky commented 2 years ago

I think that we should wait with this change since I am not sure anymore that this is a good idea