BPSTechServices / pcef-public

pcef issue tracking repo
1 stars 0 forks source link

ranking ineligible applications #267

Closed CadyLister closed 2 years ago

CadyLister commented 2 years ago

Derek, there are 8 applications that are WCD or Planning that were automatically given a funding category and so they are counted into the ranking and total # which we do not want. Can you make it so they do not have a funding category?

<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:x="urn:schemas-microsoft-com:office:excel" xmlns="http://www.w3.org/TR/REC-html40">

APP_ID | ELIGIBLE | GRANT TYPE | FUNDING CATEGORY | APPLICATION TITLE | FUNDING CATEGORY RANK | APPLICATIONS IN FUNDING CATEGORY -- | -- | -- | -- | -- | -- | -- 2707 | No | planning | planning | Sustainable Indigenous Marketplace | 11 | 42 2531 | No | planning | planning | SAMCO | 37 | 42 2594 | No | planning | planning | Climate Change | 37 | 42 2756 | No | planning | planning | EGC Planning Grant 1 | 37 | 42 2667 | No | planning | planning | GRAVITY ENERGY MACHINE PROJECT (GEM) | 37 | 42 2669 | No | planning | planning | Climate adaptation, vulnerability and community well-being project. | 37 | 42 2691 | No | planning | planning | I'm Hooked Inc. Educational and Conservation Center | 37 | 42 2718 | No | wcd | wcd | Hollywood East | 41 | 41

derekwmiller commented 2 years ago

@CadyLister is this because they are ineligible?

CadyLister commented 2 years ago

@derekwmiller yeah, the ones on this list are all inelgible (or they withdrew so I marked them ineligible so they wouldnt get pulled into the reports)

derekwmiller commented 2 years ago

@CadyLister should they be excluded from the report entirely, or excluded only from the rank?

CadyLister commented 2 years ago

@derekwmiller just from the rank/ranking

derekwmiller commented 2 years ago

@CadyLister run it now please

CadyLister commented 2 years ago

@derekwmiller just ran it and it only returned column A with the app ID's and no other info

derekwmiller commented 2 years ago

@CadyLister yeah that's interesting. I'll look in to it

derekwmiller commented 2 years ago

@CadyLister I rolled back my attempted fix. The report now includes all data but still ranks the ineligible records. The report relies on a value being present in the 'funding_category' column. I can either modify / rewrite the report or - more quickly - assign ineligible records to their own funding category so that they are ranked amongst themselves (essentially meaningless)

CadyLister commented 2 years ago

@derekwmiller please go with the easier quicker option,. thank you!

derekwmiller commented 2 years ago

@CadyLister this is resolved thanks