search

BQSKit / bqskit

Berkeley Quantum Synthesis Toolkit
Other
106 stars 31 forks source link

Add reset #212

Closed peachnuts closed 3 months ago

peachnuts commented 6 months ago

add qasm support and test files for reset.

edyounis commented 5 months ago

This PR changes how measurements are handled in the qasm decoding. It seems that there is a leakage between the mid-circuit measurement PR and the add-reset PR. This makes it hard to review this on its own, with a lot of potential for intermediate issues. You either need to fully decouple them or merge them completely before I can do a proper review.

peachnuts commented 5 months ago

This PR changes how measurements are handled in the qasm decoding. It seems that there is a leakage between the mid-circuit measurement PR and the add-reset PR. This makes it hard to review this on its own, with a lot of potential for intermediate issues. You either need to fully decouple them or merge them completely before I can do a proper review.

I merged all the changes (add reset, MMR and MMR partition) to this PR. Could you only review this PR? Maybe I can just close the other two PRs (MMR and MMR partition)?