search

BR-Visualization / brcharts

Create BR charts
https://br-visualization.github.io/brcharts/
MIT License
0 stars 0 forks source link

Added trade-off plot #30

Closed chen-chen-stat closed 3 months ago

github-actions[bot] commented 3 months ago

badge

Code Coverage Summary

Filename                Stmts    Miss  Cover    Missing
--------------------  -------  ------  -------  ---------
R/check_feature.R         345     345  0.00%    12-454
R/ci_calculation.R         92      92  0.00%    20-296
R/grouped_barchart.R       12      12  0.00%    23-35
R/pyramid_chart.R          70      70  0.00%    43-117
R/tradeoff_plot.R         890     890  0.00%    85-1244
R/utils.R                 285     285  0.00%    8-611
TOTAL                    1694    1694  0.00%

Diff against main

Filename              Stmts    Miss  Cover
------------------  -------  ------  --------
R/check_feature.R      +345    +345  +100.00%
R/ci_calculation.R      +92     +92  +100.00%
R/pyramid_chart.R        -6     +69  -98.68%
R/tradeoff_plot.R      +890    +890  +100.00%
R/utils.R                +1    +194  -67.96%
TOTAL                 +1322   +1590  -72.04%

Results for commit: d31781077f0fda690cbb4d98a106fda7d94899f2

Minimum allowed coverage is 80%

:recycle: This comment has been updated with latest results

chen-chen-stat commented 3 months ago

@Lovemore-Gakava The trade-off plot is ready for your review.

Lovemore-Gakava commented 3 months ago

@chen-chen-stat thanks for setting this up. I have added a few comments regarding adding the argument zscore and/ tscore in the functions to make them dynamic. We will need to update the readme to include the new figure. Otherwise all looks great.

github-actions[bot] commented 3 months ago

Github pages

Review the pkgdown webpage for the PR here

chen-chen-stat commented 3 months ago

@Lovemore-Gakava Thank you for your previous review and comments. The updated PR is ready for your review.