search

BR-Visualization / brcharts

Create BR charts
https://br-visualization.github.io/brcharts/
MIT License
0 stars 0 forks source link

7 create value tree #36

Closed Lovemore-Gakava closed 4 months ago

github-actions[bot] commented 4 months ago

badge

Code Coverage Summary

Filename                           Stmts    Miss  Cover    Missing
-------------------------------  -------  ------  -------  -------------------------------------------------------------------------------------------------------------------------------------
R/check_feature.R                    345     300  13.04%   12-330, 359-363, 367-370, 385-389, 404-408, 426-430, 443-448
R/ci_calculation.R                    92       0  100.00%
R/cumulative_excess_functions.R      347      40  88.47%   94-95, 105-106, 192-199, 236-247, 304-308, 443-451, 469-471
R/grouped_barchart.R                  12      12  0.00%    23-35
R/pyramid_chart.R                     76       1  98.68%   52
R/tradeoff_plot.R                    890     424  52.36%   92-140, 234, 241-242, 246-247, 289-290, 299-309, 381-387, 396-400, 503-514, 701-730, 769-808, 834-972, 980-1034, 1070-1077, 1111-1221
R/utils.R                            289      55  80.97%   443-668
R/value_tree.R                         1       1  0.00%    45
TOTAL                               2052     833  59.41%

Diff against main

Filename          Stmts    Miss  Cover
--------------  -------  ------  --------
R/utils.R            +4      +4  -1.14%
R/value_tree.R       +1      +1  +100.00%
TOTAL                +5      +5  -0.15%

Results for commit: dd91f271679ed60f4a97e6c7f096b4607b55641e

Minimum allowed coverage is 80%

:recycle: This comment has been updated with latest results

github-actions[bot] commented 4 months ago

Unit Tests Summary

  1 files    4 suites   7s :stopwatch:  32 tests  32 :white_check_mark: 0 :zzz: 0 :x: 292 runs  292 :white_check_mark: 0 :zzz: 0 :x:

Results for commit dd91f271.

:recycle: This comment has been updated with latest results.

chen-chen-stat commented 4 months ago

@Lovemore-Gakava Thank you for creating the PR. I am a bit confused about the value_tree function. It seems that the function itself already takes the example data as arguments, but it makes more sense to me if we leave the diagram parameter as blank in the function, but pass the arguments to the function in the "examples". Does this make sense to you?

github-actions[bot] commented 4 months ago

Github pages

Review the pkgdown webpage for the PR here

Lovemore-Gakava commented 4 months ago

@Lovemore-Gakava Thank you for creating the PR. I am a bit confused about the value_tree function. It seems that the function itself already takes the example data as arguments, but it makes more sense to me if we leave the diagram parameter as blank in the function, but pass the arguments to the function in the "examples". Does this make sense to you?

Agreed @chen-chen-stat - updated.