BR-Visualization / brcharts

Create BR charts
https://br-visualization.github.io/brcharts/
MIT License
0 stars 0 forks source link

11 create scatterplot #38

Closed aemabe closed 3 months ago

github-actions[bot] commented 4 months ago

badge

Code Coverage Summary

Filename                           Stmts    Miss  Cover    Missing
-------------------------------  -------  ------  -------  -------------------------------------------------------------------------------------------------------------------------------------
R/check_feature.R                    345     300  13.04%   12-330, 359-363, 367-370, 385-389, 404-408, 426-430, 443-448
R/ci_calculation.R                    92       0  100.00%
R/cumulative_excess_functions.R      347      40  88.47%   94-95, 105-106, 192-199, 236-247, 304-308, 443-451, 469-471
R/grouped_barchart.R                  12      12  0.00%    23-35
R/pyramid_chart.R                     76       1  98.68%   52
R/scatterplot_function.R             121      13  89.26%   40-42, 70-81
R/tradeoff_plot.R                    890     424  52.36%   92-140, 234, 241-242, 246-247, 289-290, 299-309, 381-387, 396-400, 503-514, 701-730, 769-808, 834-972, 980-1034, 1070-1077, 1111-1221
R/utils.R                            289      55  80.97%   443-668
R/value_tree.R                         1       1  0.00%    45
TOTAL                               2173     846  61.07%

Diff against main

Filename                    Stmts    Miss  Cover
------------------------  -------  ------  -------
R/scatterplot_function.R     +121     +13  +89.26%
TOTAL                        +121     +13  +1.66%

Results for commit: 3aefd74be34d17bb657c85f86c80b120ac0566a2

Minimum allowed coverage is 80%

:recycle: This comment has been updated with latest results

github-actions[bot] commented 4 months ago

Unit Tests Summary

  1 files    5 suites   8s :stopwatch:  37 tests  37 :white_check_mark: 0 :zzz: 0 :x: 331 runs  331 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 3aefd74b.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 4 months ago

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
scatterplot 👶 $+0.77$ $+39$ $0$ $0$ $0$
Additional test case details | Test Suite | $Status$ | Time on `main` | $±Time$ | Test Case | |:-----|:----:|:----:|:----:|:-----| | scatterplot | 👶 | | $+0.01$ | scatter_plot_expects_an_error_when_df_diff_has_two_identical_vectors_of_incremental_probabilities | | scatterplot | 👶 | | $+0.01$ | scatter_plot_expects_an_error_when_df_diff_is_missing_required_vector_s_ | | scatterplot | 👶 | | $+0.24$ | scatter_plot_will_ouput_a_ggplot_object | | scatterplot | 👶 | | $+0.27$ | scatter_plot_will_return_a_custom_warning_message_concerning_missing_data | | scatterplot | 👶 | | $+0.24$ | scatter_plot_will_return_a_visible_object_with_missing_data |

Results for commit 7bf5f83c21fa780fb8ab26d82a8f80f747b6367e

♻️ This comment has been updated with latest results.

chen-chen-stat commented 4 months ago

@aemabe Thank you for creating the PR. There are extra axis lines and ticks compared with the figure in the manuscript. Suggest adding the following arguments to the theme() function to remove the extra axis lines and ticks:

axis.line.x = element_blank(), axis.line.y = element_blank(), axis.ticks.x = element_blank(), axis.ticks.y = element_blank()

chen-chen-stat commented 4 months ago

@aemabe Another comment - We may want to avoid the use of "fig11" in the function as the function may be used outside of the context of the manuscript figures.

github-actions[bot] commented 4 months ago

Github pages

Review the pkgdown webpage for the PR here