BRAINSia / dcm-classifier

Apache License 2.0
2 stars 1 forks source link

Update Testing #26

Closed CavRiley closed 7 months ago

CavRiley commented 7 months ago

Overview

The purpose of this pull request is to increase testing coverage in order to cover the recent features added to the classifier.

Implementation

Implementation included creating more unit tests to cover new methods added to classes as well as increasing testing data for testing the variety of cases present in the classifier.

Testing

Coverage was computed for the implementation of new tests in which we saw an increase in code coverage to around 93%.

Addition of New Tests:

Problems Faced

N/A

Notes

After the new test implementation, we achieved around 93% code coverage, an almost 10% increase.

CavRiley commented 7 months ago

Here is the full coverage details:

Name                                         Stmts   Miss  Cover   Missing
--------------------------------------------------------------------------
src/dcm_classifier/dicom_config.py               4      0   100%
src/dcm_classifier/dicom_series.py              75      1    99%   134
src/dcm_classifier/dicom_validator.py           27      0   100%
src/dcm_classifier/dicom_volume.py             143      6    96%   182, 355, 451-453, 513
src/dcm_classifier/image_type_inference.py     142     16    89%   115, 177, 204, 226, 254, 277-280, 305, 411, 416, 422-428
src/dcm_classifier/study_processing.py          72      4    94%   312, 370-371, 373
src/dcm_classifier/utility_functions.py        372     34    91%   171, 181-187, 195-203, 208-213, 264, 275, 283-287, 295, 316, 387-389, 416-419, 699-700
--------------------------------------------------------------------------
TOTAL                                          835     61    93%