BRCAChallenge / BRCAMobile

0 stars 0 forks source link

refactor notification system to produce only the minimum number of notifications #17

Closed falquaddoomi closed 7 years ago

falquaddoomi commented 7 years ago

In the current implementation, in addition to variant-specific notifications all users will receive a "pre-notification" that causes them to open the app, triggering the variant-specific notifications to be processed and possibly shown. In the common case most users won't be subscribed to variants that have changed in a given update, so they'll receive a spurious notification and be taken to an empty list of relevant changes.

The "bug" here is to remove this spurious notification, yet maintain the privacy of user's variant subscriptions.

falquaddoomi commented 7 years ago

Plan to fix the above:

falquaddoomi commented 7 years ago

Work on this was started in 4ac573eae00032952261b31797d4db60ff6189eb and continued until 24ca8c22509d61a34bfbca71e4181bf306d9cdbb as of this writing. It seems to be implemented correctly, but it needs to be tested.

Caveat(s):