search

BRCAChallenge / BRCAMobile

0 stars 0 forks source link

legend modal gets clipped by screen bottom in landscape, isn't scrollable #21

Closed falquaddoomi closed 6 years ago

falquaddoomi commented 6 years ago

The "icon legend" modal that appears on the search results screen isn't scrollable and its height causes it to be clipped by the bottom of the screen in landscape mode.

falquaddoomi commented 6 years ago

Fixed in 496cd604de229e1816b2cf8cf2cd8fc0679a6e41. Specifically, the icon list is now scrollable independently of the header and close button footer. The legend modal now no longer dismisses when tapped anywhere but the "close" button, to allow the user to scroll the internal content. (It can still be dismissed by the hardware back button on Android.) Content now flows into two columns provided sufficient horizontal space.