search

BRCAChallenge / BRCAMobile

0 stars 0 forks source link

upgrading to 1.3.6+ from a previous version causes searches to crash #24

Closed falquaddoomi closed 6 years ago

falquaddoomi commented 6 years ago

Due to a change in how the store represents variants (introduced around commit 6b6ba6bfac3a7ac03beda9d80c428032e95dcd47), migrating from a pre-1.3.6 to any future version will cause searches to crash the app.

falquaddoomi commented 6 years ago

Reproduced the exception when populating the store with cached variants and following a variant using the app at commit 2bf08502703401b2ae61f700d720402d69a9cd6f, then searching with the app at commit d3091cc2a775812b5b6a97578b0f221f876c6ec9.

falquaddoomi commented 6 years ago

Verified that the migration introduced in b5601f5fdadaad55ad5ec058bb335c747ab8a58e fixes the issue. Commit 13063746a9717defc7dca8053901c32ccb5e6d49 removes the quick hack that would also fix the problem, but at a cost to performance.