search

BRGM / gml_application_schema_toolbox

GML Application Schema toolbox is a QGIS plugin allowing to manipulate OGC Complex Features
https://brgm.github.io/gml_application_schema_toolbox/
GNU General Public License v2.0
28 stars 18 forks source link

Bug/227 Attribute Error #228

Closed frida-161 closed 2 years ago

frida-161 commented 2 years ago

This PR changes a few lines in gui/load_wizard_wfs.py to fix #220 and #227. With these changes I was able to fix the Bounding Box filter in the Wizard.

codecov-commenter commented 2 years ago

Codecov Report

Merging #228 (a018c0a) into master (897aca6) will decrease coverage by 0.00%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #228      +/-   ##
==========================================
- Coverage   19.15%   19.14%   -0.01%     
==========================================
  Files          42       42              
  Lines        3702     3703       +1     
  Branches      610      610              
==========================================
  Hits          709      709              
- Misses       2941     2942       +1     
  Partials       52       52
Impacted Files Coverage Δ
..._application_schema_toolbox/gui/load_wizard_wfs.py 0.00% <0.00%> (ø)
Guts commented 2 years ago

Thanks @towa for your contribution effort! Really appreciated!

LGTM!

Could you just sort the imports as stipulated in our contribution guidelines (isort wit black profile) please?

frida-161 commented 2 years ago

Thanks for the quick reply. I fixed the imports and will make sure to use pre-commit from now on :)