search

BRGM / gml_application_schema_toolbox

GML Application Schema toolbox is a QGIS plugin allowing to manipulate OGC Complex Features
https://brgm.github.io/gml_application_schema_toolbox/
GNU General Public License v2.0
26 stars 17 forks source link

auto join 1:1 relations #249

Open frida-161 opened 1 year ago

frida-161 commented 1 year ago

This PR implements the Auto Join of 1:1 relations as described in Issue #248

codecov-commenter commented 1 year ago

Codecov Report

Merging #249 (1e03947) into master (84de3da) will decrease coverage by 0.05%. The diff coverage is 11.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
- Coverage   19.12%   19.06%   -0.06%     
==========================================
  Files          42       42              
  Lines        3708     3724      +16     
  Branches      610      560      -50     
==========================================
+ Hits          709      710       +1     
- Misses       2947     2960      +13     
- Partials       52       54       +2
Impacted Files Coverage Δ
...plication_schema_toolbox/gui/import_gmlas_panel.py 0.00% <0.00%> (ø)
...lication_schema_toolbox/core/load_gmlas_in_qgis.py 75.39% <16.66%> (-6.33%) :arrow_down:
frida-161 commented 1 year ago

@Guts Do you think we could get this feature merged?

kannes commented 1 year ago

I'd suggest a tiny change to the option label: "Automatically join 1:1 relation tables" or something similar to make it more clear what this option does. There is enough space.

frida-161 commented 1 year ago

I'd suggest a tiny change to the option label: "Automatically join 1:1 relation tables" or something similar to make it more clear what this option does. There is enough space.

Thanks for the suggestions. Now its much clearer