search

BRGM / gml_application_schema_toolbox

GML Application Schema toolbox is a QGIS plugin allowing to manipulate OGC Complex Features
https://brgm.github.io/gml_application_schema_toolbox/
GNU General Public License v2.0
28 stars 18 forks source link

WFS version negotiation #60

Closed mhugo closed 6 years ago

mhugo commented 6 years ago

In the WFS connection dialog, when the users sets the WFS server to a bad one, the plugin should warn the user that it is not the actual version of the server.

Test the version upon the first connection and store a flag to tell if it is the actual version

sgrellet commented 6 years ago

tested on v1.2.0-rc2 when setted to a bad one (ex here V2.0 on a 1.1 WFS) the following stack trace is generated AttributeError: 'NoneType' object has no attribute 'find' Traceback (most recent call last): File "C:/Users/grellets/AppData/Roaming/QGIS/QGIS3\profiles\default/python/plugins\gml_application_schema_toolbox\gui\load_panel.py", line 130, in on_connectBtn_clicked wfs = self.wfs() File "C:/Users/grellets/AppData/Roaming/QGIS/QGIS3\profiles\default/python/plugins\gml_application_schema_toolbox\gui\load_panel.py", line 104, in wfs return WebFeatureService(url=uri, version=version) File "C:\OSGEO4~1\apps\Python36\lib\site-packages\owslib\wfs.py", line 50, in WebFeatureService password=password) File "C:\OSGEO4~1\apps\Python36\lib\site-packages\owslib\feature\wfs200.py", line 65, in new username=username, password=password) File "C:\OSGEO4~1\apps\Python36\lib\site-packages\owslib\feature\wfs200.py", line 92, in init self._buildMetadata(parse_remote_metadata) File "C:\OSGEO4~1\apps\Python36\lib\site-packages\owslib\feature\wfs200.py", line 101, in _buildMetadata self.identification=ServiceIdentification(serviceidentelem) File "C:\OSGEO4~1\apps\Python36\lib\site-packages\owslib\ows.py", line 47, in init val = self._root.find(util.nspath('Title', namespace)) AttributeError: 'NoneType' object has no attribute 'find' Version de Python : 3.6.0 (v3.6.0:41df79263a11, Dec 23 2016, 08:06:12) [MSC v.1900 64 bit (AMD64)] Version de QGIS : 3.0.0-Girona Girona, 001c80b0c3

@mhugo : ticket closed, because the patch you committed will be implemented in a rc3 ?

sgrellet commented 6 years ago

tested ok on GMLAS toolbox plugin : v1.2.0-rc6 Python : 3.6.0 (v3.6.0:41df79263a11, Dec 23 2016, 08:06:12) [MSC v.1900 64 bit (AMD64)] QGIS : 3.0.1-Girona Girona, a86bec25ebw tested using http://services.sandre.eaufrance.fr/geo/eth_FXX