Closed quentinpaden closed 3 years ago
@Max2020q I see, you copied the landing page in the error template. That's not a good approach to fix it. What you can do here is show an error page with a link to a landing page.
And, you don't have to create a new design for the page. We already have a 404 page (OGV-meteor/imports/ui/pages/404.html),
The issue you need to fix is:
notFound
in file 404.html on 404 errorHello, thank you for the advice, I have reviewed the comment!
The current 404.html to me is not as good as the landing page.html.
https://github.com/BRL-CAD/OGV-meteor/blob/development/imports/ui/pages/404.html can be replaced by the https://github.com/BRL-CAD/OGV-meteor/blob/development/imports/ui/pages/landingPage.html instead
I chose the error.html approach because routing is not working on 404.html in a lot of aspects.
Most errors seem to route to error.html right now including nature 404 errors..
I am going to revert these changes and fix the 404.html template instead and the routing.
Added some more changes. Right now in OGV-meteor error.js is set up in iron-router as the default 404 page.
Because of this, my solution involved adding the 404.html to the error.html, centering the style, and trying to fix the link to home page.
Code used and cleaned up by @theamanjs in #106. Thanks!
Fixes issue with loading 404 page version of website correctly
Example: (ogv.com vs. ogv.com/test)