search

BRZ-GmbH / CovidCertificate-App-Android

Mozilla Public License 2.0
26 stars 1 forks source link

Android app shows iOS licenses in English #14

Open thgoebel opened 3 years ago

thgoebel commented 3 years ago

In the English locale you put in the licenses for iOS:

App version: 2.0.0, from Google Play

Note that the CH's Covid Certificate has the same English license text no matter the device's locale. Thus AT's Green Pass actually shows the correct-for-Android (English) license text when OS locale is DE.

thgoebel commented 3 years ago

Additionally, you have included a lot of new dependencies in 2.0.0. Most are covered indirectly via "androidx", "kotlinx", "Jackson", but some like Lyft's Kronos and the certlogic JAR blob (where is it even from?) should also be stated in the licenses as well. Currently they are missing in the English Android version shown when the local is DE.

thgoebel commented 2 years ago

Looks like you fixed this in v2.0.2 (without ever communicating it here...), but broke it again 2.2.0....