Closed cedrycm closed 2 years ago
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/blacksocialists/dual-power-app/79Ytz5kE8SUKNaLuKLnGRRBXirWU
✅ Preview: https://dual-power-app-git-update-open-design-content-blacksocialists.vercel.app
/ | /open-design |
---|---|
(view full size) |
(view full size) |
And 2 other routes:
Commit d3ebc0c40d47e61ea473696338386d5d4509ebbf (https://dual-power-app-3jov8hsdl-blacksocialists.vercel.app).
@replygirl I added some extra config options to webpack for unplugin-icons + unplugin-auto-import for us to import our custom image assets under the 'custom' collection:
import BSAGlyph from '~icons/custom/bsa-glyph.jsx'
with auto-import we can also choose not to explicitly import these and use this notation instead:
IconBsaGlyph
which will generate global types into the auto-imports.d.ts file.
note: this file also contains globals for react hooks which could be nice imo but can be removed if needed! I also chose not to do an auto-import implementation in this PR due to a linting error that's set for jsx imports. not sure if that was something that could break the vercel deployment 🤷🏾
getting there! quick notes
justify-content-start
or some other combo of grid layout utilsgrid-cols-[auto,1fr]
stack-x
thanks for the feedback! i'll go ahead make those changes 🤝
that final rebase hurt took years off my life 🧎🏾
in the live deployment, clicking on the documents tab opens one of the documents immediately for some reason
i think i might just need to wipe out those merges and rebase properly. luckily you already did the difficult part of the rebase :)
my bad! looks like i changed the img tag. should be fixed now!
This PR covers a few changes mentions in issue https://github.com/BSA-US/dual-power-app/issues/89: