search

BSC-Support-Team / GREASY

Greasy is a tool designed to make easier the deployment of embarrassingly parallel simulations in any environment.
Other
11 stars 5 forks source link

Extend MPI support to Cray compilers #2

Closed victorusu closed 3 years ago

victorusu commented 3 years ago

This PR changes the MPI search function to support a simpler compiler definition list and test the compiler after detection. Additionally in the PR removes the m4 cache files.

The advantages of this approach is that one can select the list of compilers to support in a single place, instead of multiple if else combinations. Furthermore it also tests whether the actual compiler works by testing it against a simple mpi example program.

There are a bunch of changed files, this is due to the fact that I have run aclocal && autoconf && automake.

victorusu commented 3 years ago

@PabloRodenas, @csimarro or @BSC-Support-Team, could any of you review this PR? What do you guys think?

victorusu commented 3 years ago

If one runs on a Cray this PR using

$./configure --enable-slurm

The output is

...
checking for srun... yes
checking for bjobs... no
checking for qsub... no
checking for g++... g++
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking dependency style of g++... gcc3
...

If one runs on a Cray using 

$ ./configure --enable-slurm --enable-mpi-engine

Then, the output is 

...
checking for srun... yes
checking for bjobs... no
checking for qsub... no
checking for mpicxx... no
checking for mpic++... no
checking for CC... CC
checking whether the MPI command works... yes
checking whether we are using the GNU C++ compiler... yes
checking whether CC accepts -g... yes
checking dependency style of CC... gcc3
...

If one runs in a Linux laptop

$ ./configure --enable-mpi-engine

The output is

...
checking for srun... no
checking for bjobs... no
checking for qsub... no
checking for mpicxx... /usr/bin/mpic++
checking whether the MPI command works... yes
checking whether we are using the GNU C++ compiler... yes
checking whether /usr/bin/mpic++ accepts -g... yes
checking dependency style of /usr/bin/mpic++... gcc3
...
BSC-Support-Team commented 3 years ago

Dear Victor,

I reviewed the changes and I do not see any problem for accepting the PR. Thanks for the interest on the project. On the other side, we detected a memory leak error on regex file. I just upload our changes to github today, please, review them in your fork.

Best, Pablo.

victorusu commented 3 years ago

Dear Victor,

I reviewed the changes and I do not see any problem for accepting the PR. Thanks for the interest on the project. On the other side, we detected a memory leak error on regex file. I just upload our changes to github today, please, review them in your fork.

Best, Pablo.

Dear Pablo,

Thanks for informing us about this!

Best wishes, Victor