BSData / adeptus-titanicus

Adeptus Titanicus
http://battlescribedata.appspot.com/#/repo/adeptus-titanicus
15 stars 19 forks source link

Allowed number of Princeps Seniores selections has various issues #206

Closed jorisvangestel closed 2 years ago

jorisvangestel commented 2 years ago

Describe the bug There are several issues with the selection of Princeps Seniores, as previously reported in #140 and 'fixed' in #145, which currently still exist:

  1. Number of allowed Princeps Seniores selections is '# maniples + 1', see @zopha's comment here
  2. Number of Princeps Seniores in a maniple is not limited except by 1), i.e. if you have 1 maniples, you can put 2 Princeps Seniores into a maniple, if you have 2 you can put 3 into a single maniple, etc
  3. Princeps Seniores selection doesn't take Legio Vulcanum +1 Princeps Seniores per maniple modifier into account

To Reproduce Steps to reproduce the behavior:

  1. Add a maniple
  2. Set 2 titans to have the Princeps Seniores upgrade
  3. (Optional) Select Legio Vulcanum as Titan Legion
  4. See (no) error, as this is currently actually allowed

Expected behavior At a minimum, I would expect the to be able to select only 1 Princeps Seniores if I have 1 maniple. If Legio Vulcanum is selected I would expect to be able to select 2 Princeps Seniores when I only have 1 maniple. In a perfect world I would also expect to be able to selected only 1 Princeps Seniores per maniple if my battlegroup has multiple maniples, or 2 Princeps Seniores if the specific maniple has the Lego Vulcanum selection.

Device and data (please complete the following information):

Additional context I have extensively tried to fix this. The biggest problem is 2) and stems from the fact that I can't find a way to check on a per maniple basis how many Princeps Seniores have been selected. Fixing 1) is actually straight forward as mentioned in #145 and adjusting the current roster based limit for Legio Vulcanum to fix 3) also isn't that hard.

I agree with @zopha that 2) is actually minor concern though, as I think most people don't tend to run multiple Maniple. On top of that I'm not sure this issue can even be fixed without resorting to creating separate selection entries for a 'titan with princeps' and 'titans without princeps' similar to how sergeant models work for 40k.