search

BSData / adeptus-titanicus

Adeptus Titanicus
http://battlescribedata.appspot.com/#/repo/adeptus-titanicus
15 stars 19 forks source link

Make maniples a Force selection like Lances #223

Open jorisvangestel opened 2 years ago

jorisvangestel commented 2 years ago

Is your feature request related to a problem? Please describe. We currently have 2 known issues #216 and #222 that can't be fixed due to maniples currently being a selection based of a Primary Category, this prevents validation to be properly scoped to a single 'Force of Maniple' and causes things like Legio selection to 'spill over' into other maniple selections.

Describe the solution you'd like I would like to change maniples to an actual Force selection, similar to how a Lance is a Force selection in a Household. I think this is the only way to fix the related issues.

Describe alternatives you've considered I added this suggestion to #120, but who knows how will it will be before we get around to that. I have also extensively tried to fix this issue in #207 to no avail.

Additional context I think this could potentially result in any previously created rosters from no longer working, unless battlescribe can still resolve the selection ids (the actual selection entries wont have to be changed so it might just work). It would be a necessary evil in order to fix the underlying issues though.

I don't think this would even be to hard of a change to do, but before I get in over my head again I would appreciate some buy-in from the maintainers.

nstephenh commented 1 month ago

While that's certainly an option, I think your current "unit" "model" setup works, but you need to change the constraints to be "legion in unit" and not "legion in ancestor"

BoaPi commented 1 month ago

Hi @MoDLegion, this issue can probably be closed or? With the new selector options from NewRecruit, this rework should not be necessary. In fact we probably change household to behave like maniples.