BSData / horus-heresy

Horus Heresy
http://battlescribedata.appspot.com/#/repo/horus-heresy
77 stars 78 forks source link

Questoris Household Detachment - Knights should not be abe to take generic/mechanicum warlord traits #3242

Closed BoaPi closed 3 months ago

BoaPi commented 3 months ago

Describe the bug Currently it is possible for selected knights that are also a warlord, to select from the generic or mechanicum warlord traits. This should not be possible.

As stated in the core rules, only HQ choices that are also a warlord, should be able to select warlord traits.

Only the knight with the seneschal rank, should be able to select the questoris household specifc warlord trait "Master of the household"

To Reproduce

  1. please see this list

Expected behavior

Screenshots image

Device and data (please complete the following information):

Additional context none

Petitionerscity commented 3 months ago

Surely the issue here is that knights with ranks or dark blessings usually gain the character sub-type, and so could gain a normal Warlord trait?

Eg aucteller: "A model with this upgrade increases its Weapon Skill Characteristic by +1 and gains the Character Unit Sub-type and the Aucteller special rule."

This seems to fit the first allowance in the paragraph you quote @BoaPi - "then a Character model from any other choice in the Primary detachment may be selected as the Warlord".

Mayegelt commented 3 months ago

Surely the issue here is that knights with ranks or dark blessings usually gain the character sub-type, and so could gain a normal Warlord trait?

Eg aucteller: "A model with this upgrade increases its Weapon Skill Characteristic by +1 and gains the Character Unit Sub-type and the Aucteller special rule."

This seems to fit the first allowance in the paragraph you quote @BoaPi - "then a Character model from any other choice in the Primary detachment may be selected as the Warlord".

The lower part of that paragraph says that "If any player has been required to select a non-Character model as their Warlord, or a model that is not part of a HQ choice, then that model does not receive a Warlord Trait, but counts as a Warlord for all other rules purposes."

As mentioned they are characters. But they are not HQ. So to be able to have a warlord trait you need to be a character & an HQ. This is due to the "OR" in there. The "Master of the Household" warlord trait seems to be linked to the Seneschal rank, and is allowed as the rules for the rank would override the normal rules for warlord traits not being allowed on non HQs.

BoaPi commented 3 months ago

@Mayegelt exactly this. The only seneschal rank allows a warlord trait.

Petitionerscity commented 3 months ago

My bad, and thanks for making clear :)

I wonder if it's helpful to add that info as a pop up on warlord selection for a non-hq choice?

BoaPi commented 3 months ago

that sounds like a great idea!

nstephenh commented 3 months ago

Not sure if we can do a pop-up, we could either change the name or add a rule, but that's about it.

I've made a fix, but there might be other versions of this that are funky, namely titans all have "warlord" and there's some weird restrictions on some of the existing knight warlord choices.