BSData / warhammer-age-of-sigmar

Warhammer: Age of Sigmar 3.0
http://battlescribedata.appspot.com/#/repo/warhammer-age-of-sigmar
73 stars 82 forks source link

Data Quality - Stormcast Eternals Allegiance selection has inconsistent type #3208

Closed logisticpeach closed 1 year ago

logisticpeach commented 1 year ago

The data file for the Stormcast Eternals faction has the following entry for the Allegiance selection:

<selectionEntry id="c6a3-2acf-1e46-3896" name="Allegiance" hidden="false" collective="false" import="true" type="unit">

Note the type="unit" here - most other catalogues I've inspected have the more sensible type="upgrade" here. For example, Lumineth Realmlords and Idoneth Deepkin

I would expect all datasets to have a consistent schema and treat concepts in a constant way.

exaegrum commented 1 year ago

Your expectation is unfortunately nowhere near met - there is currently a fairly large lack of consistency in general in the implementation. I would like to completely redo the system from scratch, but would like to wait until 4e in case we get indexed like 40k. I'll change this one bc it's a 5 sec fix, but in general schema issues that aren't causing problems aren't going to be touched until then.