BSData / wh40k-7th-edition

Warhammer 40,000: 7th Edition
http://battlescribedata.appspot.com/#/repo/wh40k-7th-edition
172 stars 271 forks source link

Game System Refresh #38

Closed amis92 closed 10 years ago

amis92 commented 10 years ago

Discussion started in #34 by @Millicant.

There is an initiative to clean up and organize our gst better.

I feel it's good time for us to learn about branches. It's independent "copy" of repo from a given time, which can be independently modified. Currently we have only master, from which we do releases. That's good. We'll need a development branch, on which we'll test the new Game System and comment on it. I'll go ahead and create it. @Millicant , your job will be then to put your gst in that new branch.

Changing branches is rather straightforward in GitHub app. There is branch name (master by default) in upper-right part when you're in repo view. If you click on it, you'll see branches (most of the time only master) and here you need to choose which branch to work on. It's best to change between branches while there are no uncommited changes, as these changes will stay.

So I've created new branch, new-gst. @Millicant, could you share your gst refresh with us on this branch, please? Then we'll discuss changes.

Sandy756X commented 10 years ago

Good luck!

Also, to verify that we're thinking the same thing, a simple "Other" Detachment with only an "Other" slot in it to cover anything that doesn't conform to the standard FOC? So I want to bring Knights, add and Other detachment. I want Inquisition allies, Other detachment. Right?

amis92 commented 10 years ago

Hm, that would be the easiest way.

What I was thinking, is to create the schema they presented like so:

ghost commented 10 years ago

Is unbound just the same as apocalypse but without the battle formations?

Hey @amis92, thanks for uploading your Reshaper tool. If I use it on other files, will it make them incompatible with the updated repo gst?

amis92 commented 10 years ago

Hey, @khambatta , I'm not sure I understand the question, so I'll just say what it does ;) It takes all distinct IDs of categories, profileTypes, and characteristics (which is everything what connects gsts and cats). Then it assigns each one a new, re-generated ID, and then replaces such pairs (old value, new value) in gst and in all cat files found in selected folder.

Which means, now that I've re-generated those in all of current files (on new branch) - you won't be actually able to make them compatible automatically. You can always try to use something like xslt, but it'll be tedious. I think I could try to create xslt for such cases in Reshaper (meaning when regenerating, it'd create xslt to use on other catalogues). Now I think of it, it's a good idea. It's just too late for wh40k :/

amis92 commented 10 years ago

As for Apocalypse/Unbound - Unbound allows for taking any models/entries. Which essentially means yes, it's Apoc but no (Battle) Formations.

Sandy756X commented 10 years ago

@amis92 So your list earlier isn't actually how it's laid out anymore. A Combined Arms Detachment (CAD) has a specific optional slot for Lord of War, Fortification, and from the rules all the "Other" units also go directly into it. I would suggest something more like this:

*These 3 detachments technically belong inside the Combined Arms detachment, so making them a subset seems the easiest way to make that happen. However, since things like Knights are able to stand alone, I can also see the argument for leaving them as separate instead of nested (or BOTH if we want to get crazy). Also, you are NOT limited to a number of CADs, so I can have as many CADs as I want all from different codecies as well as any number of Allied Detachments.

+This detachment should include every type: HQ, Troops, Fast Attack, Elites, Heavy Support, Lord of War, Fortification, Other and they are all 0/-1

Thoughts?

ghost commented 10 years ago

Sorry, @amis92, I mean to say I have a couple of my own cat files (Sapce Marines, DKK assault) that aren't in the repo here - I'll need to update their IDs to match the new gst file. I can do that by manually editing the xml text, but I was wondering if the Reshaper would do it for me?

amis92 commented 10 years ago

Yeah. As I feared, I understood correctly.

Simply put, no. Tough if you gather some patience, I may be able to produce XSLT for that. Then you would load that XSL into Reshaper and voila! Ready.

Now I'm producing XSLs to clean up profiles and "merge" them in #55. Might take a second. ;)

Also I've made first draft of new Game System. Please say what you think, but for a moment, don't modify profiles. Force Types are non-important for me right now.

amis92 commented 10 years ago

Ok, so in #55 I've removed all profiles except:

I'll be grateful if any/all of you'd help with re-checking files seeking modifiers and conditions no longer valid.

Cheers!