BSI-OFIQ / OFIQ-Project

Open Source Facial Image Quality
Other
38 stars 12 forks source link

If an image fails there is nothing in the results csv #33

Open tadam98s opened 3 months ago

tadam98s commented 3 months ago

I am running tests on thousands of images. After processing a few hundred I got an exception: OpenCV: termininate handler is called ! The last OpenCV error is: OpenCV(4.5.5) Error: Image step is wrong (The matrix us not continous, thus its number of rows cannot be changed( in cv::Mat::reshape, file C\Users\Mickey.conan2\p\b\open00b993b028ed5\b\src\modules\core\matrix.cpp, line 1176

Please update the program to simply try-catch such error and place the error in the result csv and continue. Surely, I suggest to append the result of every completed file into the output csv each time so that if there is an uncaught exception, the results so far will not be lost.

(some numbers are in the terminal output but best is to have the standard csv.

Best, Mickey

m-schaubert commented 3 months ago

Hi Mickey, could you please check if you have pulled the latest updates. This issue was alreaday fixed - https://github.com/BSI-OFIQ/OFIQ-Project/pull/25 Here is the corresponding diff: https://github.com/BSI-OFIQ/OFIQ-Project/pull/25/commits/d94a0475a7ed051f00cd80136328080b4f658345

tadam98s commented 3 months ago

Please also address the issue of updting the csv constantly just for the case there could be additional errors.

bbtams commented 3 months ago

Hi Mickey, please note that the sample app is just an example to demonstrate how to use the OFIQ C/C++ library. We do not intend to maintain the sample app or add new functionalities to it.