search

BSI-OFIQ / OFIQ-Project

Open Source Facial Image Quality
Other
38 stars 12 forks source link

Redundant conversion to RGB in unified quality score? #36

Closed seba-eng closed 2 months ago

seba-eng commented 2 months ago

Maybe there is something I don't see, but it seems like the input image for the unified quality score is converted from RGB to BGR (line 93 in modules\measures\src\UnifiedQualityScore.cpp) only to be converted back to RGB in CreateBlob (internally in cv::dnn::blobFromImage; line 82). Is this necessary? Color conversion is a quite expensive operation in OpenCV.

m-schaubert commented 2 months ago

Thank you, Sebastian, we have corrected it already in our implementation and will push a PR in the next time.