Closed C-Ivan-Bandilla closed 1 month ago
Still working adding confirm delete modal
Do comment if this is ready for review. Thanks
Confirm Delete
Confirm Delete on deletion conflict
https://drive.google.com/file/d/1sxjK4beko0L9OWBEKBObjwMB6L7GAX6f/view?usp=sharing
Added some client validation functions on roles and responsibilities
ready for reviewing
For the Confirm Delete modal, maybe you should use a combination of on input and change event here. What i noticed is that a user has to click away from the input field for the Delete button to enable.
There's no client feedback to the user if i were to click on the Save button with empty values
Let say i have one for the position name, you should perhaps add a red border as an indicator for Vote Selection
There was a time sir owen accessed the configuration page as a part of testing the live version on hostinger, he suggested that the "Add New Position" and in all config pages, the cursor should be the pointer one. He said that it was kinda misleading to use the cross cursor and it seems like you were taking a screenshot or snippet of your screen.
For the cancel button, can you add perhaps a border or anything that would make it appear more like button not a label.
I am wondering whether we should add some sort of tooltips and notes on how to use configuration. I'm quite sure this page isn't very intuitive to users and would sure need a lot of guidance to navigate their way through. Let's say something like.
Note: Double click on a position to edit it.
Something like that.
You decide whether we merge these changes along with a 'need issue ticket' label.
I'd like to have an issue ticket for the concerns thank you.
:tada: This PR is included in version 2.34.1 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
Added the view and edit on candidate position