BSIT-3-1-APPDEV / PUPSRC-AutomatedElectionSystem

iVOTE is a web-based voting application developed for the student academic organizations of PUP Sta. Rosa Campus.
https://ivote-pupsrc.com
4 stars 8 forks source link

feat: AT3-159 added registration schedule configuration page #267

Closed C-Ivan-Bandilla closed 1 month ago

C-Ivan-Bandilla commented 1 month ago

Table used

CREATE TABLE `registration_schedule` (
  `schedule_id` tinyint(3) UNSIGNED NOT NULL,
  `start` datetime NOT NULL,
  `close` datetime NOT NULL
);
gitguardian[bot] commented 1 month ago

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them. Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately. Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Carl-Tabuso commented 1 month ago

I would have to review PR #264 prior to this PR, correct? I think it would automatically close, should this open pr be merged?

C-Ivan-Bandilla commented 1 month ago

I would have to review PR #264 prior to this PR, correct? I think it would automatically close, should this open pr be merged?

Yes, the pr 264 first

I think it would automatically close, should this open pr be merged?

I have no prior idea if it will automatically close this pr can be merge as I had already created a branch on my local for the creation of faq page

C-Ivan-Bandilla commented 1 month ago

Up anyone hahahha will be pushing next pr soon for faq config

Carl-Tabuso commented 1 month ago

We might have to go over your PR prior to this. I remember that github does actually auto-merged a pr if its commit messages are identical to others. I don't know why is that but maybe it checks the commit hash.

Carl-Tabuso commented 1 month ago

This is working on my end. On registration, I will just have to query the registration_schedule table to check whether the schedule is open for a particular org. Is there anything else you want to add? I can approve of this.

C-Ivan-Bandilla commented 1 month ago

This can be merge if working well thank you

will follow the SQL in PHP later

github-actions[bot] commented 1 month ago

:tada: This PR is included in version 2.37.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

C-Ivan-Bandilla commented 1 month ago

here is the create-reg-schedule.php