BSIT-3-1-APPDEV / PUPSRC-AutomatedElectionSystem

iVOTE is a web-based voting application developed for the student academic organizations of PUP Sta. Rosa Campus.
https://ivote-pupsrc.com
4 stars 8 forks source link

Added table for the candidate count by position #274

Closed Ivan-Edan closed 1 month ago

Ivan-Edan commented 1 month ago

Description: This PR is about the latest enhancements when it comes to the Election Reports Module. The Changes includes:

Sample output: Screenshot (99) Screenshot (100) Screenshot (102) Screenshot (103) Screenshot (104) (P.S ignore the actual picture and description in the modal it was that sample data when it comes to my database)

Closes #259 Closes #150 Closes #146

gitguardian[bot] commented 1 month ago

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [13043212](https://dashboard.gitguardian.com/workspace/558516/incidents/13043212?occurrence=160736698) | Triggered | SMTP credentials | 9dbc36f7a746daa7ac769a0e5e702509474457f9 | src/includes/mailer-test.php | [View secret](https://github.com/BSIT-3-1-APPDEV/PUPSRC-AutomatedElectionSystem/commit/9dbc36f7a746daa7ac769a0e5e702509474457f9#diff-7c014e330afeb8f6740ef0b23948f90e2f4ac56301328b1991f074c8c3118f83R36) | | [13043212](https://dashboard.gitguardian.com/workspace/558516/incidents/13043212?occurrence=160758566) | Triggered | SMTP credentials | 8f6094154da9a750a60d7734e91ea37df89141c7 | src/includes/mailer-test.php | [View secret](https://github.com/BSIT-3-1-APPDEV/PUPSRC-AutomatedElectionSystem/commit/8f6094154da9a750a60d7734e91ea37df89141c7#diff-7c014e330afeb8f6740ef0b23948f90e2f4ac56301328b1991f074c8c3118f83R58) | | [13043212](https://dashboard.gitguardian.com/workspace/558516/incidents/13043212?occurrence=160758605) | Triggered | SMTP credentials | 46bf049c1be649427e665d5cc7ac1a4c5117d179 | src/includes/mailer-test.php | [View secret](https://github.com/BSIT-3-1-APPDEV/PUPSRC-AutomatedElectionSystem/commit/46bf049c1be649427e665d5cc7ac1a4c5117d179#diff-7c014e330afeb8f6740ef0b23948f90e2f4ac56301328b1991f074c8c3118f83L58) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/specifics/smtp_assignment#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

C-Ivan-Bandilla commented 1 month ago

(P.S ignore the actual picture and description in the modal it was that sample data when it comes to my database)

image

the json part is the actual data it can be processed to display this pr can be a referenced

https://github.com/BSIT-3-1-APPDEV/PUPSRC-AutomatedElectionSystem/pull/184#:~:text=Resource%20if%20needed%20https%3A//quilljs.com/docs/api%23editor


also I encountered an issue when there is no position, candidate and feedback available but the schedule closed

https://github.com/user-attachments/assets/ff543f87-966e-4a62-9c85-0ef03a3cb25a

it will load forever to be specific this only happen when feedback table has no data image

this is for election reports

Carl-Tabuso commented 1 month ago

This is not even responsive on all screen sizes, especially to the smallest breakpoint in mobile devices. On candidate table and feedback section, you aren't supposed to be text-wrapping. This doesn't align with what's on our mockup UI — alignment of elements, layout, and sizes of close buttons. I don't also understand why some containers have borders and some don't.

Take a close look at this video

https://github.com/user-attachments/assets/39106ce6-f06e-48f7-be53-c620ec931282


[!CAUTION] Please always check your error text file for error logs. The code block below is just one of the many errors I keep getting.

2024-07-17 12:09 pm Error: [2] Undefined variable $baseDir - C:\xampp\htdocs\PUPSRC-AutomatedElectionSystem\src\includes\result-candidates.php: 15
2024-07-17 12:09 pm Error: [2] include(\includes\session-exchange.php): Failed to open stream: No such file or directory - C:\xampp\htdocs\PUPSRC-AutomatedElectionSystem\src\includes\result-candidates.php: 15
Ivan-Edan commented 1 month ago

Will resolve this matter, thanks

Ivan-Edan commented 1 month ago

Already adjust the responsiveness and remove some border and text wrapping for the headers of the tables, for now is all the best I can do to remedy the situation, my apologies I hope you all can understand. Thanks

C-Ivan-Bandilla commented 1 month ago

The loading still exist this happen only if feedback table has no data

https://drive.google.com/open?id=1t9lUZffjshPMqsDvhSc1HGVWRAwuwyNx&usp=drive_fs

AraojoBenedict commented 1 month ago

The loading still exist this happen only if feedback table has no data

https://drive.google.com/open?id=1t9lUZffjshPMqsDvhSc1HGVWRAwuwyNx&usp=drive_fs

image added empty space in handling if feedback table has no data

AraojoBenedict commented 1 month ago

(P.S ignore the actual picture and description in the modal it was that sample data when it comes to my database)

image

the json part is the actual data it can be processed to display this pr can be a referenced

184

also I encountered an issue when there is no position, candidate and feedback available but the schedule closed

Election.Reports.-.Google.Chrome.2024-07-17.11-44-14.mp4 it will load forever to be specific this only happen when feedback table has no data image

this is for election reports

not used in utilizing quill from a json file. I opt on sticking fetching data from db. Here is the sample of displaying description from inputting the position description from the configuration module: ![Uploading image.png…]()