BSIT-3-1-APPDEV / PUPSRC-AutomatedElectionSystem

iVOTE is a web-based voting application developed for the student academic organizations of PUP Sta. Rosa Campus.
https://ivote-pupsrc.com
4 stars 8 forks source link

Added backend to the user password reset in settings #278

Closed Ivan-Edan closed 1 month ago

Ivan-Edan commented 1 month ago

Description: This PR is the continuation of applying functions in the settings page for the reset password module.

Additional Notes:

Ivan-Edan commented 1 month ago

Already addressed the requested changes

Ivan-Edan commented 1 month ago

Fix the settings as follows added red border in the input field if the user input incorrect password: image Fix the eye toggle missing in text field: image

the modal timer will be implemented in the next pr.

Ivan-Edan commented 1 month ago

Added features in the reset password such as:

gitguardian[bot] commented 1 month ago

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [13043212](https://dashboard.gitguardian.com/workspace/558516/incidents/13043212?occurrence=161099144) | Triggered | SMTP credentials | a462e595eb85fea13f3061265b08e679b27c18fc | src/includes/mailer-test.php | [View secret](https://github.com/BSIT-3-1-APPDEV/PUPSRC-AutomatedElectionSystem/commit/a462e595eb85fea13f3061265b08e679b27c18fc#diff-7c014e330afeb8f6740ef0b23948f90e2f4ac56301328b1991f074c8c3118f83L36) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secret safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate this secret](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/specifics/smtp_assignment#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Ivan-Edan commented 1 month ago

Already updated the code and remove the requested links and added indentation to the code

Ivan-Edan commented 1 month ago

Already addressed the requested changes.

Carl-Tabuso commented 1 month ago

Already addressed the requested changes.

Can you provide a demo?

Ivan-Edan commented 1 month ago

Sample Demo of changing the password: Screen Recording - Made with FlexClip.webm