In order to reduce the risk of regressions, it would be interesting to add a testing pipeline to new PRs
Within the pipeline, the following things should be tested:
If the library builds
If the E2E tests pass
Make sure that you effectively re-use the stage to minimize the minutes used:
Cache the node_modules and the pnpm cache so that they can be re-used in other pipelines
Split the pipeline into different stages to effectively run it
We can also lint the code (For this, we don't need a build folder, so it might be interesting to manually install the dependencies)
Build the application and make sure to make the artifacts available within the pipeline (which can be used if we want to implement CD for the next branch)
Use the puppeteer image in order to test the application so that we don't need to install the dependencies again (The E2E tests need to have a build project, so make sure to use it from the build stage)
In order to reduce the risk of regressions, it would be interesting to add a testing pipeline to new PRs
Within the pipeline, the following things should be tested:
Make sure that you effectively re-use the stage to minimize the minutes used:
pnpm
cache so that they can be re-used in other pipelinesnext
branch)build
stage)