search

BTBurke / caddy-jwt

JWT middleware for the Caddy server
MIT License
113 stars 40 forks source link

Adding the support for the configurable token sources. #39

Closed igor-petruk closed 5 years ago

igor-petruk commented 5 years ago

This includes the actual list of checks and customisations such as cookie or query param names. Fixes #38.

igor-petruk commented 5 years ago

@BTBurke Is there anything I can improve in the pull request? :)

BTBurke commented 5 years ago

Hey Igor. I'm on vacation with my family so I won't take a look until after the new year. Sorry for the delay.

On Dec 19, 2018, 11:25 AM, at 11:25 AM, Igor Petruk notifications@github.com wrote:

@BTBurke Is there anything I can improve in the pull request? :)

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/BTBurke/caddy-jwt/pull/39#issuecomment-448613538

igor-petruk commented 5 years ago

Oh, I see. No problem. Have a great time!

magikstm commented 5 years ago

I tested this PR locally on Windows 7 x64. It fixes #38 and works with http.login.

LGTM.

igor-petruk commented 5 years ago

Any chance to take a look now? :) I just wanted to try it from the binary on caddyserver.com

BTBurke commented 5 years ago

Looks good. Appreciate the contribution.

BTBurke commented 5 years ago

I just deployed it via the caddy website. It's version 3.7.0. Give it a shot and let me know if you have any problems.

igor-petruk commented 5 years ago

Hi.

Thanks! Everything works as expected.