BTCGPU / BTCGPU

Current work on BTCGPU
http://bitcoingold.org
MIT License
660 stars 334 forks source link

Replay Protection Implementation #51

Closed martin-key closed 7 years ago

martin-key commented 7 years ago

Two-way replay protection must be provided in Bitcoin Gold Refer to #18

The solution must feature:

Bounty: 250 BTG Bonus 50 BTG if the task is finished before 25.10.2017 12:00 UTC

vattay commented 7 years ago

I'll take a stab at this, even though someone with more BTC experience will probably stomp me. Building project now.

h4x3rotab commented 7 years ago

Great! We also have one person working on this and maybe we can collaborate to speed up the progress. (All the bounty belongs to you.)

vattay commented 7 years ago

Collab == good. I'm on Bitcoin Gold slack as LxF77.

drewdotpro commented 7 years ago

I thought this was a "work in progress" for the last 2+ weeks? https://github.com/BTCGPU/BTCGPU/issues/18#issuecomment-334234022

If that's the case, share the branch for bounty hunters to have a starting point.

LeaTex commented 7 years ago

@StarbuckBG where will you get the 250+50 BTG? If you fork the BTC blockchain, you need that amount in BTC today.

martin-key commented 7 years ago

No. When the fork happens and wallet is available you will be paid.

On 21 Oct 2017, at 19:54, Lea MM notifications@github.com wrote:

@StarbuckBG https://github.com/starbuckbg where will you get the 250+50 BTG? If you fork the BTC blockchain, you need that amount in BTC today.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/BTCGPU/BTCGPU/issues/51#issuecomment-338416407, or mute the thread https://github.com/notifications/unsubscribe-auth/ADrjrVsl4HAiFLJCM18tFP634UXS-cusks5suiGzgaJpZM4QBACc.

LeaTex commented 7 years ago

paid whit BTG? ok, where do you get it? you need to make a transaction to my wallet. and the inputs came from another wallet. these 250+50 can not "appear magically", thay need to exists in the BTG blockchain.

martin-key commented 7 years ago

They will be paid as soon as the network is started. Having your name and eventually your commit will be proof that you have completed the issue. We will add the transaction to the ticket on closing it as a proof that we have paid to you.

On 21 Oct 2017, at 20:09, Lea MM notifications@github.com wrote:

paid whit BTG? ok, where do you get it? you need to make a transaction to my wallet. and the inputs came from another wallet. these 250+50 can not "appear magically", thay need to exists in the BTG blockchain.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/BTCGPU/BTCGPU/issues/51#issuecomment-338417532, or mute the thread https://github.com/notifications/unsubscribe-auth/ADrjrScZZLTL_kPaObQsKnBt52ZlGLOFks5suiVMgaJpZM4QBACc.

LeaTex commented 7 years ago

I think you are not answering my question. Where will you get 250+50 BTG to pay me?

martin-key commented 7 years ago

There is a premining with time locked funs for the next 3 years. Most of the funds are for development and dev bounties.

On 21 Oct 2017, at 20:18, Lea MM notifications@github.com wrote:

I think you are not answering my question. Where will you get 250+50 BTG to pay me?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/BTCGPU/BTCGPU/issues/51#issuecomment-338418154, or mute the thread https://github.com/notifications/unsubscribe-auth/ADrjrUnZjTRT9pndN7vPA7GfxcCZ47F2ks5suidKgaJpZM4QBACc.

LeaTex commented 7 years ago

ok, thanks for your answer.

notf0und commented 7 years ago

Then, if I solve this I will be payed with 250 BTG locked for the next 3 years? Sounds great!

martin-key commented 7 years ago

If you solve it, you get the 250 BTG after the mainnet is started.

Sent from my iPhone 7 plus

On Oct 22, 2017, at 8:41 AM, Fabián Gonzalo Artur de la Villarmois notifications@github.com wrote:

Then, if I solve this I will be payed with 250 BTG locked for the next 3 years? Sounds great!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

EliasZ commented 7 years ago

So the premine is not time locked after all? Because otherwise you would need 250 BTC right now.

martin-key commented 7 years ago

75% of the premine is locked for the next 3 year. 25% are released on launch to support the dev bounties and the need of servers, infrastructure etc.

Sent from my iPhone 7 plus

On Oct 22, 2017, at 11:21 AM, Elias notifications@github.com wrote:

So the premine is not time locked after all? Because otherwise you would need 250 BTC right now.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

sammy007 commented 7 years ago

Just cherry-pick it from bitcoin-abc what a problem.

krtschmr commented 7 years ago

200k premine, that's lots of bounty hunting :>

andre-amorim commented 7 years ago

Replay protection has todo with time() Note that's GNU specific. date +%s%6N for microseconds.

cryptosi commented 7 years ago

Maybe change to "will"

image

leto commented 7 years ago

mainnet will not launch without 2way replay protection, it's cooking, so is implementing is better

stefek99 commented 7 years ago

Bounty for a critical feature opened 4 days before the planned fork.

What could possibly go wrong?

😇

Ashrafnet commented 7 years ago

I don't think you guys going to launch the fork on time, this 2 way replay protection must be done before launch. I think the whole project is scam, its goal is just to manipulate the market, and it did the goal!

leto commented 7 years ago

not_launch

martin-key commented 7 years ago

If it was scam none of the people will work nonstop for this. Moreover the mainnet will be released later than the fork.

Sent from my iPhone 7 plus

On Oct 23, 2017, at 9:57 AM, Duke Leto notifications@github.com wrote:

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

EliasZ commented 7 years ago

What mechanism is used for timelocking the funds?

RhettCreighton commented 7 years ago

working on this

sammy007 commented 7 years ago

What a scam party, now ZCL/ZEN scammers joined the train.

RhettCreighton commented 7 years ago

Hi @sammy007 , nice to see you, were you able to get it to compile yet?

krtschmr commented 7 years ago

nobody were able. not even the fix compile errors commit fixed that shit.

krtschmr commented 7 years ago

@EliasZ mechanism is easy to explain. they promise us to keep the funds.

how dare you questioning this? ;)

martin-key commented 7 years ago

I have it working on my 2 MacBooks and on eu-node.bitcoingold-official.org http://eu-node.bitcoingold-official.org/ .

On 23 Oct 2017, at 11:26, krtschmr notifications@github.com wrote:

nobody were able. not even the fix compile errors commit fixed that shit.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/BTCGPU/BTCGPU/issues/51#issuecomment-338584612, or mute the thread https://github.com/notifications/unsubscribe-auth/ADrjrfi0yB1HS6XzOuGPAOd3KQdFWsgJks5svE3QgaJpZM4QBACc.

RhettCreighton commented 7 years ago

@krtschmr cd depends; make ; <wait 30 minutes> cd .. ./autogen.sh; ./configure --prefix=/home/username/BTCGPU/depends/x86_64-pc-linux-gnu make

3389 commented 7 years ago

连重放保护都不会做的垃圾币,傻逼廖翔,自己偷摸挖了这么多币只拿出这点来,下次麻烦多那点钱给搬砖的。

RhettCreighton commented 7 years ago

Please review my pull request: https://github.com/BTCGPU/BTCGPU/pull/62

sammy007 commented 7 years ago

@heyrhett

were you able to get it to compile yet?

If something smells like shit, you dont have to taste it. (c) FYMIYWF

At least not until there is a functional testnet.

ethan-nx commented 7 years ago

The code compiles on Arch Linux just fine. Posting a "Replay protection bounty" just a few days before the fork is a bad joke. Seriously, given all the premined coins you reserve for yourself, you could not handle this on time?

If you cannot compile the code, refer to issue #60, don't post it here.

Cheers, Ethan

w0lph commented 7 years ago

This is a scam. Their website claims replay protection as already implemented. Their argument of: "If it was scam none of the people will work nonstop for this.", doesn't hold water. People may be working nonstop with a hidden agenda or simply being fooled by this.

ocminer commented 7 years ago

I neither see funds/premine time locking nor replay protection implemented yet, can someone point me to that code ?! It seems I can just mine blocks like on every other (bitcoin-) fork.

imerkle commented 7 years ago

What is this ? Killing all the crypto markets! Biggest meme of the century

John1231983 commented 7 years ago

It is scam because this method did not implement but the website noticed that it has implemented. Please remove the feature

GalRogozinski commented 7 years ago

Is someone working on implementing replay protection using SIGHASH_FORK and would like some help?

ileathan commented 7 years ago

Oh look... 35 blocks to go - scammers.

lucaspelloni2 commented 7 years ago

any news?

ethan-nx commented 7 years ago

Since there is no replay protection yet, see #66

adhood commented 7 years ago

Bitcoin Gold is not launching today.

I know they are calling it a "fork", and many people are expecting it to be similar to the Bitcoin Cash fork (where the snapshot and launch occurred simultaneously), but the only thing happening today is they are making a copy of the Bitcoin blockchain for future use with Bitcoin Gold.

Nothing is going live today. You will not be able to mine, send, receive or do anything else with Bitcoin Gold other than trade it on the few exchanges currently supporting it.

See #39 -- The Bitcoin Gold team has advised that the testnet and mainnet have not been coded yet and they will be reopening a bounty ticket soon with details for anyone who wants to create it for them. I'm sure replay protection will be included during the development of Bitcoin Gold and will be ready by launch, but that is not today and I have not seen an ETA for the actual launch.

AkliOnet commented 7 years ago

They know what there are doing. They have just what is necessary, the minimal to launch their fork . And their need to launch quickly is understandable.

Replay protection unavailable: It's a bad point ! Really But they have mesured the the risk in term of timing before they do it. What I don't like is that they launch making the people money at risk.

You all criticized their premining, but I find it reasonable. when you understand that it's their project and their work that will build a good part of the value of their exit (say half of the value, probably more after, the other is inherited of bitcoin and people investment) . And if you are so irritated is because you believe in their project...

If they succeed in the next day, I think we could applaud this dream team !

Hey the team ? I have only an ATI Radeon 3600 HD ! When your receive your fat money, please send me 1 btg to thank me for the support so I can mine on one of your pool. I will post my address . We never know.

Support them ! for what they bring

martin-key commented 7 years ago

If all the people that has spend that many times in writing all the posts has focused to write just 1 line of code for each sentence of hate, we would have replay protection, unique address format, Lightning network and whatever possible to be done.

On 24 Oct 2017, at 3:18, CryptoInvestment notifications@github.com wrote:

People did not understand , the team is composed of two men from china , one hardcore dev, you can see it in his pseudo, the other Martin from Bulgaria, he don't laugh!

They have also a man from Colombia!! They are hungry there ! They have also a man from Spain!! Crisis since 2008!

And one strategist from the USA, who today will not admit that the united states have the most concentrated population of strategist !!

They know what there are doing. They have just what is necessary, the minimal to launch their fork . And their need to launch quickly is understandable.

Replay protection unavailable: It's a bad point ! Really But they have mesured the the risk in term of timing before they do it. What I don't like is that they launch making the people money at risk.

You all criticized their remaining, but I find it reasonable. when you understand that it's their project and their work that will build a good part of the value of their exit (say half of the value, probably more after, the other is inherited of bitcoin and people investment) . And if you are so irritated is because you believe in their project...

If they succeed in the next day, I think we could applaud this dream team !

Hey the team ? I have only an ATI Radeon 3600 HD ! When your receive your fat money, please send me 1 btg to thank me for the support so I can mine on one of your pool. I will post my address . We never know.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/BTCGPU/BTCGPU/issues/51#issuecomment-338833513, or mute the thread https://github.com/notifications/unsubscribe-auth/ADrjrT76kE_Aeo5sILLgHKiPMUt3ODPhks5svSzXgaJpZM4QBACc.

martin-key commented 7 years ago

If you will just stay and hate you can just start a hate chat than spamming the place people are trying to do something. I don’t believe to the names of the people, I believe to their actions. It’s is 3.23 AM my time and I’m still working, not sitting to see how I’m going to be hated, I’m working as I believe in the idea.

If the world was full of doers, not with haters we would be all over the universe and creating things that no one has ever though of. When you are just staying there hating, you are just waisting you time, than try to create a better place for everyone.

On 24 Oct 2017, at 3:22, Martin Kuvandzhiev martinkuvandzhiev@gmail.com wrote:

If all the people that has spend that many times in writing all the posts has focused to write just 1 line of code for each sentence of hate, we would have replay protection, unique address format, Lightning network and whatever possible to be done.

On 24 Oct 2017, at 3:18, CryptoInvestment <notifications@github.com mailto:notifications@github.com> wrote:

People did not understand , the team is composed of two men from china , one hardcore dev, you can see it in his pseudo, the other Martin from Bulgaria, he don't laugh!

They have also a man from Colombia!! They are hungry there ! They have also a man from Spain!! Crisis since 2008!

And one strategist from the USA, who today will not admit that the united states have the most concentrated population of strategist !!

They know what there are doing. They have just what is necessary, the minimal to launch their fork . And their need to launch quickly is understandable.

Replay protection unavailable: It's a bad point ! Really But they have mesured the the risk in term of timing before they do it. What I don't like is that they launch making the people money at risk.

You all criticized their remaining, but I find it reasonable. when you understand that it's their project and their work that will build a good part of the value of their exit (say half of the value, probably more after, the other is inherited of bitcoin and people investment) . And if you are so irritated is because you believe in their project...

If they succeed in the next day, I think we could applaud this dream team !

Hey the team ? I have only an ATI Radeon 3600 HD ! When your receive your fat money, please send me 1 btg to thank me for the support so I can mine on one of your pool. I will post my address . We never know.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/BTCGPU/BTCGPU/issues/51#issuecomment-338833513, or mute the thread https://github.com/notifications/unsubscribe-auth/ADrjrT76kE_Aeo5sILLgHKiPMUt3ODPhks5svSzXgaJpZM4QBACc.

AkliOnet commented 7 years ago

@StarbuckBG Did you find my post as a hate post ?

ICPPDS commented 7 years ago

I'm glued to this like it's the final episode of Game of Thrones season 8.