Unsigned Transaction save/export error

BTCGPU / electrum

ElectrumG; Bitcoin Gold thin client

MIT License

19 stars 17 forks source link

Unsigned Transaction save/export error #33

Closed dickieminton closed 6 years ago

dickieminton commented 6 years ago

Unsigned transactions created in a watching only wallet are saved (exported) with the input values missing. So transactions can not be signed offline! In effect cold storage doesn't work.

When attempting to sign Error message : ! "Value"

dickieminton commented 6 years ago

btg_transaction

h4x3rotab commented 6 years ago

Legacy P2PKH Bitcoin addressees don’t need the amount to be signed. However this is not true for BIP143 style sighash. It won’t work if Electrum tries to read the amount from an transaction exported without the amount.

We should check how Electrum handles SegWit tx and always turn on BIP143 when exporting tx.