search

BTCPrivate / BitcoinPrivate-legacy

Bitcoin Private is a Bitcoin and Zclassic fork which uses ZK-SNARK technology for privacy and fungibility.
Other
283 stars 132 forks source link

p2sh error when sweeping private keys into BTCP electrum wallet. #122

Closed ericdzen closed 6 years ago

ericdzen commented 6 years ago

Describe the issue

When I try to sweep my private keys over to the BTCP wallet I am getting a p2sh error.

Can you reliably reproduce the issue?

If so, please list the steps to reproduce below:

  1. Export private keys from ZCL wallet.
  2. Install BTCP electrum wallet
  3. Hover the Wallets menu options, go down to private keys, and select the sweep option.
  4. Paste all private keys into the text box and press next.
  5. p2sh error displays in a modal. *Note - During the snapshot I was using a 2fa ZCL wallet and switched that wallet to a multi-signature wallet post fork.

Expected behaviour

Private keys can be swept into the BTCP wallet without running into a p2sh error.

Actual behaviour + errors

p2sh error occurs when trying to sweeps keys into BTCP electrum wallet.

The version of Bitcoin Private you were using:

Version P!1.0.0

Machine specs:

gmc513 commented 6 years ago

Yes I am having the same issue, I had my zcl in the 1.0 wallet as well. I am also getting the p2sh error

tinkermade commented 6 years ago

Yes I am having the exact same issue as above. I initially created a 2FA wallet and discovered that couldn't move ZCL to an exchange address, and was going to have issues. I used the work-around to create a Multi-sig wallet to access funds. All of my ZCL addresses begin with T3 and I'm pretty nervous that this is going to impact importing ZCL private keys into BTCP wallet.

Error: A tiny pop up with a p2sh error occurs when trying to sweep keys into BTCP electrum wallet.

The version of Bitcoin Private you were using: Version P!1.0.0 [standard] zcltobtcpsweeperror

Machine specs: OS name + version: Windows 10 Education (Version: 1703) CPU: 2.8GHz RAM: 16.00 GB

Ayms commented 6 years ago

You can consider using https://github.com/Ayms/bitcoin-transactions

See also https://bitcointalk.org/index.php?topic=2827163.msg31273044#msg31273044 (simple examples, same applies for p2sh/multisig addresses)

ericdzen commented 6 years ago

I wrote another ticket under the Bitcoin Private Electrum wallet project and I was able to resolve this issue there. https://github.com/BTCPrivate/electrum-btcp/issues/13

gmc513 commented 6 years ago

USE YOUR SEED PHRASE FROM YOUR ZCL WALLET. THAT WORKED FOR ME 

On Sunday, March 4, 2018 12:54 PM, Eric Dzengeleski <notifications@github.com> wrote:

I wrote another ticket under the Bitcoin Private Electrum wallet project and I was able to resolve this issue there. BTCPrivate/electrum-btcp#13— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

ragnarrevenge commented 6 years ago

Seed phrase from ZCL? When? During sweep or when creating new wallet?

On Mar 4, 2018 1:04 PM, "gmc513" notifications@github.com wrote:

USE YOUR SEED PHRASE FROM YOUR ZCL WALLET. THAT WORKED FOR ME

On Sunday, March 4, 2018 12:54 PM, Eric Dzengeleski < notifications@github.com> wrote:

I wrote another ticket under the Bitcoin Private Electrum wallet project and I was able to resolve this issue there. BTCPrivate/electrum-btcp#13— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/BTCPrivate/BitcoinPrivate/issues/122#issuecomment-370249684, or mute the thread https://github.com/notifications/unsubscribe-auth/AhjI97EgmaMaL7XSDbMMELUUzli4lp13ks5tbCyegaJpZM4SbEWN .

gmc513 commented 6 years ago

Creating new wallet Sent from Yahoo Mail on Android

On Mon, Mar 5, 2018 at 7:57 AM, ragnarrevengenotifications@github.com wrote: Seed phrase from ZCL? When? During sweep or when creating new wallet?

On Mar 4, 2018 1:04 PM, "gmc513" notifications@github.com wrote:

USE YOUR SEED PHRASE FROM YOUR ZCL WALLET. THAT WORKED FOR ME

On Sunday, March 4, 2018 12:54 PM, Eric Dzengeleski < notifications@github.com> wrote:

I wrote another ticket under the Bitcoin Private Electrum wallet project and I was able to resolve this issue there. BTCPrivate/electrum-btcp#13— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/BTCPrivate/BitcoinPrivate/issues/122#issuecomment-370249684, or mute the thread https://github.com/notifications/unsubscribe-auth/AhjI97EgmaMaL7XSDbMMELUUzli4lp13ks5tbCyegaJpZM4SbEWN .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

ragnarrevenge commented 6 years ago

Thank you so much. It worked for me, and I moved my btcp to a better wallet immediately. I have had issues with the electrum wallet, so I don't trust it.

On Mar 5, 2018 9:50 AM, "gmc513" notifications@github.com wrote:

Creating new wallet Sent from Yahoo Mail on Android

On Mon, Mar 5, 2018 at 7:57 AM, ragnarrevengenotifications@github.com wrote: Seed phrase from ZCL? When? During sweep or when creating new wallet?

On Mar 4, 2018 1:04 PM, "gmc513" notifications@github.com wrote:

USE YOUR SEED PHRASE FROM YOUR ZCL WALLET. THAT WORKED FOR ME

On Sunday, March 4, 2018 12:54 PM, Eric Dzengeleski < notifications@github.com> wrote:

I wrote another ticket under the Bitcoin Private Electrum wallet project and I was able to resolve this issue there. BTCPrivate/electrum-btcp#13— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/BTCPrivate/BitcoinPrivate/issues/122#issuecomment- 370249684, or mute the thread https://github.com/notifications/unsubscribe-auth/ AhjI97EgmaMaL7XSDbMMELUUzli4lp13ks5tbCyegaJpZM4SbEWN .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/BTCPrivate/BitcoinPrivate/issues/122#issuecomment-370442970, or mute the thread https://github.com/notifications/unsubscribe-auth/AhjI945L-cwf3TKRnQIiOjCJ2ZSbouagks5tbVC2gaJpZM4SbEWN .

tinkermade commented 6 years ago

Ayms, thanks for sharing to your tool. I'm still stuck with this multi-sig ZCL wallet that I can't import private keys from into BTCP electrum wallet. I tried your tx.js script, but there are a few variables that I don't understand, mainly previndex. Please help me to understand:

node tx.js BTCP create ` prevtx=(is this the transaction ID from the previous address (below on the next line)? Need clarification please) prevaddr=(the address where ZCL would have been sent from prior to this address (probably chronological?)) prevamount= (I assume it would be the amount of the last transaction [prevaddr=] from the line above) previndex=(I have no clue. Can't find on any block explorer. need major clarification) privkey= (I assume the private key of the address (below on the next line?) addr=(the address where my ZCL balance was before the snapshot?) fees= (info found on block explorer or electrum wallet details) amount= (info found on block explorer or electrum wallet details)

Thank you immensely for any clarity you can offer.

Ayms commented 6 years ago

Since this thread is not the place to discuss this, I have opened an issue https://github.com/Ayms/bitcoin-transactions/issues/31#issue-303451989 and will reply there