search

BTCPrivate / BitcoinPrivate-legacy

Bitcoin Private is a Bitcoin and Zclassic fork which uses ZK-SNARK technology for privacy and fungibility.
Other
284 stars 132 forks source link

Experiment with re-enabling accounts #159

Closed jc23424 closed 6 years ago

interbiznw commented 6 years ago

Built and seems to work good so far for me, Will be doing more testing with accounts and the addresses generated for each account soon

interbiznw commented 6 years ago

Further testing has went well, No issues found around re-enabling accounts

izgzhen commented 6 years ago

Hello, I was curious why accounts are not supported here? What is the rationale?

Mrwh0 commented 6 years ago

internal node accounting

jc23424 commented 6 years ago

Accounts weren't supported in the original zcash codebase because of the extra work required to get them working with shielded balances. Also, accounts were never really fully fleshed out in the bitcoin reference implementation.

In the 0.17 release of bitcoin, accounts will be deprecated and eventually fully removed. This branch is available here because a couple of payment processors / merchant integrations rely on accounts, but it will probably NOT be officially merged.

Pega88 commented 6 years ago

referenced in https://github.com/GENERALBYTESCOM/batm_public/pull/73, as required by BATM. Otherwise whole account logic would need to be manually implemented in BATM to make sure to be able to make payments (i.e. look up UTXO, combine UTXO until amount is reached, or manual sweep all change addresses back to 1 main address). Using accounts would very much avoid this.

would suffice for regular txns, shielded arre not in scope for now.