search

BTCPrivate / BitcoinPrivate-legacy

Bitcoin Private is a Bitcoin and Zclassic fork which uses ZK-SNARK technology for privacy and fungibility.
Other
285 stars 132 forks source link

Deactivate POW Difficulty Bomb #206

Closed SnippleRifsky closed 5 years ago

SnippleRifsky commented 5 years ago

Commented out all instances of the PowDiffBomb

mattpass commented 5 years ago

Seems to have removed all traces of bomb value setting and implementation, seems good to me. I assume you generated to 600,000+ and it didn't kick in as a super safety check @SnippleRifsky?

Just need someone else to confirm on this also, or I'll check too but looks spot on.

dskjkljdas commented 5 years ago

concur

mattpass commented 5 years ago

Great, so 3 of us confirming the code looks fine, just need a couple of people to confirm it's tested. Should be absolutely fine, but you don't know till you've tested.

bigdaveakers commented 5 years ago

Make that 4, although I like coding standards and therefore like curly braces in my IFs. However, refactoring the entire codebase to some standards to satisfy mild OCD is probably never going to happen!

SnippleRifsky commented 5 years ago

Generated blocks on a local node in -regtest to the specified blockheight for the PoWDifficultyBomb. Once this blockheight was surpassed, the difficulty had no change indicating the removal of the PoWDifficultyBomb was a success.

bigdaveakers commented 5 years ago

Need to check deprecation.cpp and deprecation.h as there is an additional limit set at 800,000

Could do with alignment as this reminds of an upcoming deprecation