BTCTaras / kristscape

The ComputerCraft web browser that works across servers
7 stars 6 forks source link

Stop using load for a lookup table #27

Closed dmarcuse closed 8 years ago

dmarcuse commented 8 years ago

seriously who thought using load would be a good idea

dmarcuse commented 8 years ago

also it works for either numeric or string keys now

dmarcuse commented 8 years ago

why did you make a lookup table for this anyways why not just use string.char

Luca0208 commented 8 years ago

The lookup table is so that you can just use lookup[stuff] with strings AND the number indexes.

dmarcuse commented 8 years ago

well i fixed it

Luca0208 commented 8 years ago

I think what you have is a really good solution 👍

dmarcuse commented 8 years ago

just checked the git blame, I wouldn't expect anyone but @BTCTaras to use load instead of string.char and I guessed right

BTCTaras commented 8 years ago

haha ha

BTCTaras commented 8 years ago

uhh

BTCTaras commented 8 years ago

ha

bauen1 commented 8 years ago

Hum what does the Revert button do ?

dmarcuse commented 8 years ago

dont even dare @bauen1 you're partially responsible for this mess too you know

bauen1 commented 8 years ago

Uhm i left the load there because i though it had a reason to be there

BTCTaras commented 8 years ago

it was a temporary solution to a temporary problem and i accept full responsibility

dmarcuse commented 8 years ago

i'll fix the other lookup tables eventually too

Luca0208 commented 8 years ago

Why can everyone press revert. I don't have write access why am I able to (in theory) revert it.

BTCTaras commented 8 years ago

that would create a fork where it is reverted iirc

dmarcuse commented 8 years ago

am i the only one that DOESNT have access to the revert button?

bauen1 commented 8 years ago

XD

BTCTaras commented 8 years ago

yes because you own the pr

Luca0208 commented 8 years ago

Probably because you already have a version

dmarcuse commented 8 years ago

later i'll make a proper metatable powered color lookup table

Luca0208 commented 8 years ago

actually it's not because he owns the PR

i can revert
Luca0208 commented 8 years ago

That's the SCRIPT PR and I can revert