search

BTMorton / angular2-grid

A drag/drop/resize grid-based plugin directive for angular2
https://bmorton.co.uk/angular/
MIT License
354 stars 159 forks source link

check for null row and col #244

Closed lkirby1266 closed 7 years ago

lkirby1266 commented 7 years ago

After upgrading to 2.0.5 from 2.0.2, we are seeing situations where the pos.row is NaN (probably null). Added a check to default the row to 1 in that case. Added same for col even though we never saw col with an invalid value.

BTMorton commented 7 years ago

Why have you added all the dist files? And why change the version?

lkirby1266 commented 7 years ago

I tried various things to get npm to install the module from my fork but I couldn't get it to work. Wasn't thinking that those commits would be passed through to the pull request. Really just the first commit should be included.

BTMorton commented 7 years ago

Change included in v2.0.6