BTMorton / angular2-grid

A drag/drop/resize grid-based plugin directive for angular2
https://bmorton.co.uk/angular/
MIT License
354 stars 159 forks source link

Load listeners on demand #287

Closed bruiztorres closed 6 years ago

bruiztorres commented 6 years ago

I'm using your library in order to display some widgets within a dashboard. Since the dashboard in my app is just for displaying information (there is no way to edit the position and size of the widgets) it doesn't make sense to load some listeners that are not going to be fired.

AFAIK there is no "angular" way to attach/detach listeners conditionally (angular/angular#7626). It seems it won't be implemented in short time so I just implemented this solution as proposed in the thread.

I experienced an improvement in terms of performance so I guess it could be useful for others. @BTMorton I have tried to add some unit tests but I'm unable to run them locally. Am I missing something? Maybe you can give me a clue about that. Thanks in advance.

Please let me know your questions/concerns.