search

BTNC / distro-win

Torch installation in a self-contained folder for windows with msvc, and most changes have already been merged to torch/distro. However since torch is decommissioned in favor of pytorch, this repository is no longer maintained.
BSD 3-Clause "New" or "Revised" License
24 stars 4 forks source link

Problem in Windows installation due to spaces in library file path #10

Closed mtiezzi closed 7 years ago

mtiezzi commented 7 years ago

Hi, I'm trying to install torch on Windows 10 64 bit. I've installed all programs required, but I got an error during installation (using install.bat), and I am not able to solve it. I will attach the log of the error

logtorchwin.txt

BTNC commented 7 years ago

It is due to blas\lapack libraries' path are not handled properly when they have spaces. The fix has been checked in. Please git pull latest changes and retry. Thanks for the report.

mtiezzi commented 7 years ago

You're welcome. Thank you very much it solved the problem, the installation succeded. I'll close the issue. I'd also like to report some bugs I found. I report them here, however if you want me to open another issue tell me.

bug1

However thanks for your efforts in developing this , Windows needs torch!

BTNC commented 7 years ago

'th' on windows is not as fascinating as its counter party on *nix systems. I know those 'bugs' but I did not spend much time investigating them as long as they are not blockers to use torch.

The dataset problem is due to sizeof(long) is 32 bit on windows while is 64 bit on linux and macos. I did update torch's memory size/offset, element count etc from long to ptrdiff_t, but I did not touch longtensor and longstorage. It will not be a problem if you use float tensor (I can not guarantee, at least I did not encounter problems). If 32 bit long tensor is enough, you can try the torch.DiskFile.longSize() api. However if you depend on 64 bit long tensor, you have to switch back to your ubuntu torch. Torch owner expressed the idea to update torch's type usages(like long -> int64_t), however as it is not a blocker for users on linux and macos, we may not see the update in foreseeing future.

mtiezzi commented 7 years ago

Thank you very much