BU-CS673 / bubolo

MIT License
3 stars 6 forks source link

Added base charging animation #389

Closed Nesciosquid closed 10 years ago

Nesciosquid commented 10 years ago

Fixed incorrect if/else block in BaseSprite that prevented animationState from ever returning to 0 from 1.

Should be an extremely minor update, since the animation logic was written and tested weeks ago.

ChristopherCanfield commented 10 years ago

Reviewing now

ChristopherCanfield commented 10 years ago

Nice work. Review:

Thanks for implementing this!

Nesciosquid commented 10 years ago

Doh! I remembered to remove a debug call at the top of the method, but forgot about that one.

Thanks for catching it! Should be fixed now.

-Aaron

On Tue, Apr 29, 2014 at 5:32 PM, Christopher D Canfield < notifications@github.com> wrote:

Nice work. Review:

  • Please remove the debug println call on line 76 of AIBaseController

Thanks for implementing this!

— Reply to this email directly or view it on GitHubhttps://github.com/BU-CS673/bubolo/pull/389#issuecomment-41735032 .

ChristopherCanfield commented 10 years ago

Thanks - approved