Pillbox and Base Tweaks - Githubissues

BU-CS673 / bubolo

MIT License

3 stars 6 forks source link

Pillbox and Base Tweaks #390

Closed Brandonthom closed 10 years ago

Brandonthom commented 10 years ago

Pillboxes are no longer automatically capturable when neutral. Bases deplete resources when refilling tanks and refill supplies themselves over time.

Brandonthom commented 10 years ago

I am watching for Aaron's pull request to be finished to handle any potential merge conflicts.

ChristopherCanfield commented 10 years ago

Thanks - just merged it in

Brandonthom commented 10 years ago

Conflicts resolved

ChristopherCanfield commented 10 years ago

Reviewing now

ChristopherCanfield commented 10 years ago

Review:

We seem to have lost the base charging animation that Aaron just added. Previously, when I went to a base I owned, it would animate while I sat on it. I took damage and used up bullets, but that still didn't result in the base charging animation playing. Can you please look into this?

I don't see any other issues.

Brandonthom commented 10 years ago

Now try it. That if statement is getting nested.

ChristopherCanfield commented 10 years ago

Thanks - trying now

ChristopherCanfield commented 10 years ago

Nice work - approved