BU-CS673 / bubolo

MIT License
3 stars 6 forks source link

Canfield-release -> production #393

Closed ChristopherCanfield closed 10 years ago

ChristopherCanfield commented 10 years ago
ChristopherCanfield commented 10 years ago

I'm going to quickly try to get the tank icon that Ethan created to display on the lwjgl window

Nesciosquid commented 10 years ago

Looks like the network bugs are sorted.

I don't see any obvious syntax issues, all unit tests pass.

One regression was found, where pillboxes on client-side games spawn explosions at their location when they shoot.

We can try and look into this before merging, or we can move ahead and bite the bullet.

Nesciosquid commented 10 years ago

Moving forward despite the regression -- worth it to get these features into Master for the presentation.

pmdouglas commented 10 years ago

I am not seeing that bug when run net/client test apps in Canfield release branch On Apr 30, 2014 6:19 PM, "Aaron Heuckroth" notifications@github.com wrote:

Looks like the network bugs are sorted.

I don't see any obvious syntax issues, all unit tests pass.

One regression was found, where pillboxes on client-side games spawn explosions at their location when they shoot.

We can try and look into this before merging, or we can move ahead and bite the bullet.

— Reply to this email directly or view it on GitHubhttps://github.com/BU-CS673/bubolo/pull/393#issuecomment-41858547 .

Nesciosquid commented 10 years ago

Nevermind, regression was fixed! Nice work.