BU-ISCIII / buisciii-tools

set of helper tools for bu-isciii management of its core services portfolio.
GNU General Public License v3.0
1 stars 13 forks source link

Remove absolute path for wkhtmltopdf executable #275

Closed saramonzon closed 1 month ago

saramonzon commented 1 month ago

bu_isciii/conf/configuration_dev.json Outdated "delivery_template_path_file": "templates/jinja_template_delivery.j2", "html_template_path_file": "templates/html_service_template.html", "path_to_css": "assets/css", "wkhtmltopdf_path": "/home/smonzon/micromamba/envs/buisciii/bin/wkhtmltopdf", Member @svarona svarona 6 minutes ago Shouldn't we used a more generic path here? If /data/bi is mounted, the original one should work.

Member Author @saramonzon saramonzon now you'r rigth, I'll leave the original one for But i don't like this solution very much, I think if we make sure the dependencies are well installed in the env and the executable is in the path you shoudn't need to set an absolute path for this.

We need to review how dependencies are installed and the installation instructions so we can remove the path