Code review manual - Githubissues

BU-Spark / bu-spark

The start of Spark! Tech Resources

MIT License

4 stars 16 forks source link

Code review manual #41

Closed mannyakosah closed 5 months ago

mannyakosah commented 7 months ago

added notes from google doc

github-actions[bot] commented 7 months ago

Visit the preview URL for this PR (updated for commit 9f8d435):

https://bu-spark-tech-resources--pr41-code-review-manual-rgrnuqnk.web.app

_{(expires Thu, 23 May 2024 15:54:56 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 8a78b8ada582dba127483163c71de6aae2e537df}

cloudflare-workers-and-pages[bot] commented 5 months ago

Deploying bu-spark-github-io with Cloudflare Pages

Latest commit:	`9f8d435`
Status:	✅ Deploy successful!
Preview URL:	https://42198a2f.bu-spark-github-io.pages.dev
Branch Preview URL:	https://code-review-manual.bu-spark-github-io.pages.dev

View logs

funkyvoong commented 5 months ago

In terms of the site organization do we want the code review docs to be its own section or do we want to stick it in an already existing section? (@langdon)

So far we have the following sections:

Data Science Project Documentation Guidelines
Requesting Compute Resources
Spark! Git Guidelines
Spark! Project Organization
Spark! Tech Stack

langdon commented 5 months ago

Why don't we change it to be "spark guidelines" and move code and git under it?

langdon commented 5 months ago

can you take a look at the conflicts and resolve them? looks like it didn't have the latest pull.