search

BU-Tools / uHAL_AXI_regmap

Tools for building AXI slave VHDL from uHAL address tables.
Apache License 2.0
4 stars 4 forks source link

adapting regmap to yml2hdl v0.3 #19

Open taquionbcn opened 2 years ago

taquionbcn commented 2 years ago

Hi @andrewpeck and @dgastler ,
I'm adapting the regmap tool to the new yml2hdl version, please can you grant me permission to push to my own branch wile I develop the changes?

Thank you!

dgastler commented 2 years ago

Ok., please follow this when working on the repo: https://nvie.com/posts/a-successful-git-branching-model/

taquionbcn commented 2 years ago

Hi @dgastler , thank you!

taquionbcn commented 2 years ago

Hi @andrewpeck & @dgastler ,

I have a question about how constants are created because I see a behavior and I'm not sure if is correct or a bug.

Running: python3 regmap/build_vhdl_packages.py -s True -x address_tables/modules/FM.xml -o HAL/ctrl/src/FM/ --mapTemplate templates/axi_generic/template_map_withbram.vhd FM

When running regmap without yml2hdl option, the constants of each record are created in the same FM_PKG.vhd is this correct or they also should be created in FM_PKG_DEF.vhd I ask this because when using the yml2hdl option the FM_PKG.vhd is completely different create form the yml2hdl tool, so I have to move the defaults to the FM_PKG_DEF.vhd

This problem of the constants only happens with the BRAM memories, when are "signals specified in XML" the constants are correctly created in the FM_PKG_DEF.vhd

For now I will keep the moving of defaults to the DEF pkg as an option only triggered when yml2hdl is used and if you tell me should be the default I will change it.

Cheers,

dacieri commented 1 year ago

Hi @dgastler @taquionbcn @andrewpeck, it looks like this issue has not been solved yet. Are there plans to integrate the latest version of yml2hdl in the regmap tool?

taquionbcn commented 1 year ago

Hi @dacieri I'm a bit sidetracked these days with slides, I will check it by the end of the week