search

BU-hammerTeam / PyHammer

A Python Spectral Typing Suite
MIT License
53 stars 14 forks source link

Default metallicity should be set to 0 for the by-eye check #2

Closed ctheissen closed 8 years ago

ctheissen commented 8 years ago

The widest spectral template coverage is for [Fe/H] = 0 (or close to zero), so it makes sense for this to be the starting value.

zephyr5050 commented 8 years ago

Do you not think the default metallicity on the eyecheck should be what the guessing algorithm determined?

westukiah commented 8 years ago

I like using the best guess just like for the spectral type

On Aug 13, 2016, at 2:49 AM, zephyr5050 notifications@github.com wrote:

Do you not think the default metallicity on the eyecheck should be what the guessing algorithm determined?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

ctheissen commented 8 years ago

I didn't realize it was supposed to default to the best guess. For all my spectra it defaulted to the same thing, which was a G0 with a metallicity of -1.5. I just thought this was the default. Sounds like there's something else going on.

Is it only comparing the region of my spectrum, our the entire region of the template? I think the plotting should only show the region of overlap, not the regions without overlap between the template and the input spectrum.

zephyr5050 commented 8 years ago

Can you email me a few of your spectra? We've only really started the testing phase of this so I'm sure there's plenty of setups and cases we haven't tested yet. I'll take a look at what's going on with your spectra and see what can be done for them.

zephyr5050 commented 8 years ago

Closing this issue. The original issue turned out to be caused by something else which are working to resolve.