search

BU-hammerTeam / PyHammer

A Python Spectral Typing Suite
MIT License
53 stars 14 forks source link

Output line & band measurements? #20

Open jradavenport opened 7 years ago

jradavenport commented 7 years ago

The IDL Hammer version returned a table of equivalent widths and band measurements, especially Balmer series and TiO values (particularly useful for low-mass star work, and computing zeta). Any hope of getting this functionality back into PyHammer?

aurorayk commented 7 years ago

We can very easily have PyHammer write the spectral indices we calculate for each spectrum for metallicity/spectral type determination to a table. We don't compute EWs, just spectral indices, so doing EWs would be a bit more work, but possible if that were something that would improve the code. Let me know if the spectral indices would be OK or if you are really looking for equivalent widths, and I will work on implementing that!

jradavenport commented 7 years ago

Having the option to save all the indices you're already computing would be a helpful (verbose) output!

I would argue there is value in providing the same features the original Hammer produced, at least for the K and M dwarfs. The EW and Errors are computed here for IDL Hammer

jbochanski commented 7 years ago

I think preserving the original EW measurements would be a good idea since that would make comparisons to previous works really straightforward. On Tue, Oct 24, 2017 at 12:45 PM James Davenport notifications@github.com wrote:

Having the option to save all the indices you're already computing would be a helpful (verbose) output!

I would argue there is value in providing the same features the original Hammer produced, at least for the K and M dwarfs. The EW and Errors are computed here https://github.com/jradavenport/TheHammer/blob/master/code/ew.pro for IDL Hammer

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/BU-hammerTeam/PyHammer/issues/20#issuecomment-339055244, or mute the thread https://github.com/notifications/unsubscribe-auth/ABIK6gRu9jXc0ZASknkijuDfh9cvGd2Jks5svhQNgaJpZM4QDOSu .

-- John Bochanski Director of Computer Science Assistant Professor of Physics Rider University johnbochanski.com


*Follow CLAS on social media:*
https://www.facebook.com/riderclas/ <https://www.facebook.com/riderclaes/>
https://twitter.com/RiderCLAS
https://www.instagram.com/riderclas/
aurorayk commented 7 years ago

Awesome! Thanks for the feedback!

Ok so I think a quick first step would be to save the spectral indices we calculate to a table-- I will start working on that now.

Then I think we could make an option in the input GUI to calculate EWs if the user wants that as an output-- this will take a bit more time but we can definitely do it!