search

BU-hammerTeam / PyHammer

A Python Spectral Typing Suite
MIT License
53 stars 14 forks source link

Not compatible with Python 2 #3

Closed ctheissen closed 8 years ago

ctheissen commented 8 years ago

I'm not sure if this is something you want to deal with, but it's good to have compatibility with both. On a related but different not, you might want to implement Travis.

zephyr5050 commented 8 years ago

At this point I'm mostly focused on getting a version working in python 3. It's been challenging enough getting that to work consistently across ask versions and platforms. I know a lot of people still use python 2 so it might be a good long term goal to branch a python 2 version, but that is not a trivial task at this point. Anyone else have any thoughts on this?

And forgive my ignorance, but what is Travis?

danfeldman90 commented 8 years ago

I think I agree with Brandon here. It's likely not a trivial task to make both compatible, since it would require a lot of changes, but it is a worthy goal once the Python 3 version is up and running well. Do we know if most users are currently on one version of Python or if it's a mix?

On Sat, Aug 13, 2016 at 11:58 AM, zephyr5050 notifications@github.com wrote:

At this point I'm mostly focused on getting a version working in python 3. It's been challenging enough getting that to work consistently across ask versions and platforms. I know a lot of people still use python 2 so it might be a good long term goal to branch a python 2 version, but that is not a trivial task at this point. Anyone else have any thoughts on this?

And forgive my ignorance, but what is Travis?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/aurorayk/New_Hammer/issues/3#issuecomment-239627826, or mute the thread https://github.com/notifications/unsubscribe-auth/ABYXF9VtN7CYkE0Zg703pLDHnxyDvR-Jks5qfemJgaJpZM4Jjssk .

Daniel Feldman Boston University Graduate Student Department of Astronomy danfeld@bu.edu danfeldman90@gmail.com (917) 608-3850

ctheissen commented 8 years ago

You can look here for a survey of Python use in Astronomy: http://astrofrog.github.io/blog/2015/05/09/2015-survey-results/

ctheissen commented 8 years ago

Also, Travis (https://docs.travis-ci.com/user/languages/python) is a package for continuous integration. In a nutshell, it constantly checks to make sure your code works as Python versions and dependencies update.

zephyr5050 commented 8 years ago

As stated, we're not planning on supporting Python 2 at this point. We're going to focus on getting this working in Python 3 and possibly support Python 2 down the line. Besides, the article indicates that of the Python 2 users, 62% haven't switched because they have no incentive to do so. Consider this program the incentive.