search

BU-hammerTeam / PyHammer

A Python Spectral Typing Suite
MIT License
53 stars 14 forks source link

Spec temp update #37

Closed broulston closed 4 years ago

broulston commented 5 years ago

I've updated PyHammer to include two new spectral classes: carbon star (C) and white dwarf (WD). I've labelled these as types 8 and 9. I've added new carbon lines to the indices list, and wider Balmer lines for the WDs.

The WDs like to confuse PyHammer between O,A,B,F. So if the initial fit is one of these (O,B,A,F,WD) then Halpha is fit with a Gaussian and the sigma width is compared with the WD template. This accurately separates the WDs and leaves the accuracy of the other classes as they were.

zephyr5050 commented 5 years ago

@broulston Since you initiated this, are you able to change this pull request to merge into the Developer-Branch instead of Master? I would want to do a full review of this branch before the merge, but would then want to merge into the Developer-Branch for testing before pushing to Master. I like to keep master as a pristine, working version as much as possible.

broulston commented 5 years ago

@zephyr5050 I believe I've switched the pull request to be merged into the Developer-Branch now